Skip to content

Fix #17 consistent pattern-mask#18

Open
ottenhoff wants to merge 2 commits into
1EdTech:masterfrom
ottenhoff:pattern-mask
Open

Fix #17 consistent pattern-mask#18
ottenhoff wants to merge 2 commits into
1EdTech:masterfrom
ottenhoff:pattern-mask

Conversation

@ottenhoff

Copy link
Copy Markdown

No description provided.

data-patternmask-message=Maximum of 6 digits or a decimal point permitted<br/>
</p>
<qti-extended-text-interaction class="qti-height-lines-3" patternMask="[0-9\.]+" data-patternmask-message="Maximum of 6 digits or a decimal point permitted" format="plain" expected-length="6" response-identifier="RESPONSE">
<qti-extended-text-interaction class="qti-height-lines-3" pattern-mask="[0-9\.]+" data-patternmask-message="Maximum of 6 digits or a decimal point permitted" format="plain" expected-length="6" response-identifier="RESPONSE">

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To add another layer of consistency, we should change this example to be consistent with what's in the QTI 3 conformance item: qti3 -> Advanced -> Q5 - Extended Text Entry Interaction -> baseType-string -> extended-text-sv-4.xml

...which is: pattern-mask="([0-9.]{0,6})" data-patternmask-message="Maximum of 6 digits or decimal points permitted"

...and lines 23-24 should be: pattern-mask="([0-9.]{0,6})" <br/>data-patternmask-message="Maximum of 6 digits or decimal points permitted" <br/>

...and let's update line 22 because qti-expected-length isn't a valid QTI attribute and should be expected-length.

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, updated

<math xmlns="http://www.w3.org/1998/Math/MathML">
<mrow> <mn>14</mn> <mo class="sign">×</mo> <mrow> <mi>tan</mi> <mo>⁡</mo> <mfenced> <mrow> <mn>67</mn> </mrow> </mfenced> </mrow>
</mrow>
</math> = <qti-text-entry-interaction class="qti-input-width-6" expected-length="6" pattern-mask="[0-9\.]+" data-patternmask-message="Maximum of 6 digits or a decimal point permitted" response-identifier="RESPONSE10"/>

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To add another layer of consistency, we should change this to be consistent with what's in the QTI 3 conformance item: qti3 -> Basic -> Q20 - Text Entry Interaction -> baseType-string -> text-entry-sv-3.xml

...which is: pattern-mask="([0-9.]{0,6})" data-patternmask-message="Maximum of 6 digits or decimal points permitted"

...and line 44 should be: qti-input-width-6, pattern-mask="([0-9.]{0,6})", data-patternmask-message="Maximum of 6 digits or decimal points permitted"<br/>

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, updated

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants