Repository navigation
Use Statamic's own fast YAML parser where it has one - #2
Merged
Merged
Conversation
Statamic is getting the same parser in core. On versions that have it, Flatpack parses with Statamic's and leaves its own copy unused; older versions keep using Flatpack's.
DanielDarrenJones
marked this pull request as ready for review
November 10, 2026 17:14
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Statamic now has the same fast YAML parser in core (
Statamic\Yaml\FastParser, statamic/cms#15838, merged into6.xand due in the release after 6.40). On a Statamic version that has it, Flatpack parses with Statamic's and leaves its own copy unused. Older versions, Statamic 5 included, keep using Flatpack's, so the supported versions don't change.Flatpack::statamicHasFastParser()checks once whetherStatamic\Yaml\FastParser::parse()exists.Flatpack::parseFrontMatter()(fields read on demand) uses Statamic's parser when it does.Yamlbinding wraps Symfony's plainYamlinstead ofSymfonyFastin that case, since Statamic'sYaml::parse()calls its own parser.Checks
bin/parity '6.x-dev'passes locally against statamic/cms 5b605541f, with the core parser detected and in use.