fix(quick-start): recover failed directions in one retry - #811
Open
huyanxius wants to merge 4 commits into
Open
Conversation
A direction retry could lock sibling failures once the node returned to generating. Permit retries during generation only when the referenced task snapshot is failed. Users can continue recovering the same action without replacing completed directions.
The controller regression needs to preserve retries after one direction starts generating. Exercise two failed sibling snapshots while the node remains active and generating. The test prevents direction recovery from returning to the previous state lock.
Separate retry buttons forced users to coordinate internal direction state manually. Group failures by node, retry them sequentially, and preserve the latest successful run. One recovery action now keeps completed directions and reports any remaining failure.
Quick Start needs a regression for the single-action recovery experience. Verify sequential retries, the shared busy label, and the preserved-results guidance. The test guards the user-facing path that previously required manual retry ordering.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Codecov Report❌ Patch coverage is @@ Coverage Diff @@
## main #811 +/- ##
==========================================
- Coverage 87.07% 87.06% -0.01%
==========================================
Files 288 288
Lines 21520 21536 +16
Branches 3294 3300 +6
==========================================
+ Hits 18738 18750 +12
- Misses 1856 1857 +1
- Partials 926 929 +3
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 2 files with indirect coverage changes 🚀 New features to boost your workflow:
|
xyh202131
approved these changes
Aug 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Quick Start 现在会一次补跑同一动作中所有失败方向,同时保留已经成功的方向,避免用户手动判断并排序多个内部重试。
Why
生产中的多方向动作生成在上游限流和线路异常后出现了部分方向失败。原实现一旦某个方向进入重试,节点就会回到生成态,后续失败方向会被 Controller 拒绝,用户看到多个重试入口却无法可靠完成恢复。
Changes
Implementation
Verification
npm test -- src/features/workflow-controller/controller.test.ts src/pages/quick-start/index.test.tsx:2 个测试文件、242 个测试通过。npm run typecheck:通过。npx oxlint src/features/workflow-controller/controller.ts src/features/workflow-controller/controller.test.ts src/pages/quick-start/index.tsx src/pages/quick-start/index.test.tsx:通过。npx oxfmt --check src/features/workflow-controller/controller.ts src/features/workflow-controller/controller.test.ts src/pages/quick-start/index.tsx src/pages/quick-start/index.test.tsx:通过。npm run build:通过;仅有既有分块体积提示。git diff --check:通过。Scope
Related Issues
Closes #808