Repository navigation
fix: revalidate when using CacheMode::NoCache - #174
Open
beanow-at-crabnebula wants to merge 2 commits into
Open
beanow-at-crabnebula wants to merge 2 commits into
beanow-at-crabnebula wants to merge 2 commits into
Conversation
Assisted-by: claude-opus-5-5
Assisted-by: claude-opus-5-5
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #174 +/- ##
==========================================
+ Coverage 85.87% 90.19% +4.32%
==========================================
Files 19 19
Lines 7502 11470 +3968
==========================================
+ Hits 6442 10345 +3903
- Misses 1060 1125 +65 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Contributor
Author
|
The failed CI check seems to be a test flake. It's a |
beanow-at-crabnebula
added a commit
to beanow-at-crabnebula/plugins-workspace
that referenced
this pull request
Sep 24, 2026
`max_ttl` is only a limit there, so responses without `max-age` or `Expires` get a hard-coded 1 hour `default_ttl`. Not configurable until 06chaynes/http-cache#175 is settled. `CheckNow` now revalidates with a conditional request, from 06chaynes/http-cache#174. Assisted-by: claude-opus-5-5
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #173
Ensures we're using
conditional_fetchas the documentation forNoCachesuggests.While keeping the forced
Cache-Control: no-cacherequest header like the existing behavior.Includes a regression test on
http-cache-reqwestsimilar to surrounding tests there.Note: not included in this PR is whether the
NoCachecomment should be updated to mention theno-cacheheader being set.Assisted-by: claude-opus-5-5