DT-137: Return clearer error messages #137#138
Merged
Conversation
abdotop
force-pushed
the
137-return-clearer-error-messages
branch
from
a96da89 to
12f04f2
Compare
… improve error logging in getOne function
kigiri
reviewed
May 18, 2026
| let timeoutId: number | undefined | ||
| if (init?.timeoutMs) { | ||
| timeoutId = setTimeout(() => controller.abort(), init.timeoutMs) | ||
| } |
Member
There was a problem hiding this comment.
this should not be handled here in this API, but instead when we call it, instead of doing:
{ timeoutMs: 3600 }
We would do:
{ signal: AbortSignal.timeout(3600) }
👍
kigiri
reviewed
May 18, 2026
| } | ||
| } | ||
|
|
||
| export function fetchErrorDetails(err: unknown): string { |
Member
There was a problem hiding this comment.
I don't like this generic error details, I think it's a bad abstraction, to be relevant we want the caller to define the error details correctly when recieved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Improve error handling and clarity in API responses