Conversation
…ching related entities in details view
…ll rendering in DeploymentPage
abdotop
force-pushed
the
133-database-relations-improvements-inline-enums-and-fetch-related-entities-in-details-view
branch
from
2b93ae9 to
7ae68c2
Compare
kigiri
reviewed
May 11, 2026
| obj[col.name] = col | ||
| return obj | ||
| }, {} as Record<string, ColumnInfo>), | ||
| })) |
Member
There was a problem hiding this comment.
Object.fromEntries(t.columns.map((col) => [col.name, col]))) as Record<string, ColumnInfo>
kigiri
reviewed
May 11, 2026
| <tr | ||
| class='hover:bg-base-200/50 cursor-pointer transition-colors border-b border-base-200/50 last:border-b-0' | ||
| onClick={() => | ||
| navigate({ params: { drawer: 'view-row', 'row-id': rowId, rt: null } })} |
Member
There was a problem hiding this comment.
move the interaction to a click on the primary key
…handling and improve table rendering
kigiri
reviewed
May 13, 2026
| @@ -559,7 +665,7 @@ const TableContent = ({ rows }: { rows: AnyRecord[] }) => { | |||
| key={index} | |||
Member
There was a problem hiding this comment.
I think we should use row.id here over index
kigiri
approved these changes
May 13, 2026
kigiri
approved these changes
May 15, 2026
kigiri
deleted the
133-database-relations-improvements-inline-enums-and-fetch-related-entities-in-details-view
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Enhance database relations by adding support for inline enums and fetching related entities in details view