views/core: Delete all message info popup parameters from inner popups.

Now that the inner popups can exit to the outer popup without having to
initialize it, we can remove the parameters of MsgInfoView class from
its inner popup classes and their respective show_* functions.

Tests updated.

Author: Niloth-p

tests/ui_tools/test_popups.py

@@ -503,19 +503,13 @@ def mock_external_classes(self, mocker: MockerFixture, msg_box: MessageBox) -> N
         self.full_rendered_message = FullRenderedMsgView(
             controller=self.controller,
             message=self.message,
-            topic_links=OrderedDict(),
-            message_links=OrderedDict(),
-            time_mentions=list(),
             title="Full Rendered Message",
         )
 
     def test_init(self, msg_box: MessageBox) -> None:
         assert self.full_rendered_message.title == "Full Rendered Message"
         assert self.full_rendered_message.controller == self.controller
         assert self.full_rendered_message.message == self.message
-        assert self.full_rendered_message.topic_links == OrderedDict()
-        assert self.full_rendered_message.message_links == OrderedDict()
-        assert self.full_rendered_message.time_mentions == list()
         assert self.full_rendered_message.header.widget_list == msg_box.header
         assert self.full_rendered_message.footer.widget_list == msg_box.footer
 
@@ -574,19 +568,13 @@ def mock_external_classes(self, mocker: MockerFixture, msg_box: MessageBox) -> N
         self.full_raw_message = FullRawMsgView(
             controller=self.controller,
             message=self.message,
-            topic_links=OrderedDict(),
-            message_links=OrderedDict(),
-            time_mentions=list(),
             title="Full Raw Message",
         )
 
     def test_init(self, msg_box: MessageBox) -> None:
         assert self.full_raw_message.title == "Full Raw Message"
         assert self.full_raw_message.controller == self.controller
         assert self.full_raw_message.message == self.message
-        assert self.full_raw_message.topic_links == OrderedDict()
-        assert self.full_raw_message.message_links == OrderedDict()
-        assert self.full_raw_message.time_mentions == list()
         assert self.full_raw_message.header.widget_list == msg_box.header
         assert self.full_raw_message.footer.widget_list == msg_box.footer
 
@@ -644,18 +632,12 @@ def mock_external_classes(self, mocker: MockerFixture) -> None:
         self.edit_history_view = EditHistoryView(
             controller=self.controller,
             message=self.message,
-            topic_links=OrderedDict(),
-            message_links=OrderedDict(),
-            time_mentions=list(),
             title="Edit History",
         )
 
     def test_init(self) -> None:
         assert self.edit_history_view.controller == self.controller
         assert self.edit_history_view.message == self.message
-        assert self.edit_history_view.topic_links == OrderedDict()
-        assert self.edit_history_view.message_links == OrderedDict()
-        assert self.edit_history_view.time_mentions == list()
         self.controller.model.fetch_message_history.assert_called_once_with(
             message_id=self.message["id"],
         )

zulipterminal/core.py

@@ -348,61 +348,23 @@ def show_msg_sender_info(self, user_id: int) -> None:
             "area:user",
         )
 
-    def show_full_rendered_message(
-        self,
-        message: Message,
-        topic_links: Dict[str, Tuple[str, int, bool]],
-        message_links: Dict[str, Tuple[str, int, bool]],
-        time_mentions: List[Tuple[str, str]],
-    ) -> None:
+    def show_full_rendered_message(self, message: Message) -> None:
         self.show_pop_up(
             FullRenderedMsgView(
-                self,
-                message,
-                topic_links,
-                message_links,
-                time_mentions,
-                f"Full rendered message {SCROLL_PROMPT}",
+                self, message, f"Full rendered message {SCROLL_PROMPT}"
             ),
             "area:msg",
         )
 
-    def show_full_raw_message(
-        self,
-        message: Message,
-        topic_links: Dict[str, Tuple[str, int, bool]],
-        message_links: Dict[str, Tuple[str, int, bool]],
-        time_mentions: List[Tuple[str, str]],
-    ) -> None:
+    def show_full_raw_message(self, message: Message) -> None:
         self.show_pop_up(
-            FullRawMsgView(
-                self,
-                message,
-                topic_links,
-                message_links,
-                time_mentions,
-                f"Full raw message {SCROLL_PROMPT}",
-            ),
+            FullRawMsgView(self, message, f"Full raw message {SCROLL_PROMPT}"),
             "area:msg",
         )
 
-    def show_edit_history(
-        self,
-        message: Message,
-        topic_links: Dict[str, Tuple[str, int, bool]],
-        message_links: Dict[str, Tuple[str, int, bool]],
-        time_mentions: List[Tuple[str, str]],
-    ) -> None:
+    def show_edit_history(self, message: Message) -> None:
         self.show_pop_up(
-            EditHistoryView(
-                self,
-                message,
-                topic_links,
-                message_links,
-                time_mentions,
-                f"Edit History {SCROLL_PROMPT}",
-            ),
-            "area:msg",
+            EditHistoryView(self, message, f"Edit History {SCROLL_PROMPT}"), "area:msg"
         )
 
     def open_in_browser(self, url: str) -> None:

zulipterminal/ui_tools/views.py

@@ -1798,16 +1798,10 @@ def __init__(
         self,
         controller: Any,
         message: Message,
-        topic_links: Dict[str, Tuple[str, int, bool]],
-        message_links: Dict[str, Tuple[str, int, bool]],
-        time_mentions: List[Tuple[str, str]],
         title: str,
     ) -> None:
         self.controller = controller
         self.message = message
-        self.topic_links = topic_links
-        self.message_links = message_links
-        self.time_mentions = time_mentions
         width = 64
         widgets: List[Any] = []
 
@@ -1912,16 +1906,10 @@ def __init__(
         self,
         controller: Any,
         message: Message,
-        topic_links: Dict[str, Tuple[str, int, bool]],
-        message_links: Dict[str, Tuple[str, int, bool]],
-        time_mentions: List[Tuple[str, str]],
         title: str,
     ) -> None:
         self.controller = controller
         self.message = message
-        self.topic_links = topic_links
-        self.message_links = message_links
-        self.time_mentions = time_mentions
         max_cols, max_rows = controller.maximum_popup_dimensions()
 
         # Get rendered message
@@ -1944,16 +1932,10 @@ def __init__(
         self,
         controller: Any,
         message: Message,
-        topic_links: Dict[str, Tuple[str, int, bool]],
-        message_links: Dict[str, Tuple[str, int, bool]],
-        time_mentions: List[Tuple[str, str]],
         title: str,
     ) -> None:
         self.controller = controller
         self.message = message
-        self.topic_links = topic_links
-        self.message_links = message_links
-        self.time_mentions = time_mentions
         max_cols, max_rows = controller.maximum_popup_dimensions()
 
         # Get rendered message header and footer