Skip to content

Commit 9e7846c

Browse files
Ari Pollaktimabbott
authored andcommitted
Refactor user retrieval & add comment
1 parent 0453c8e commit 9e7846c

File tree

1 file changed

+12
-6
lines changed

1 file changed

+12
-6
lines changed

adapter.coffee

Lines changed: 12 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -61,19 +61,25 @@ class Zulip extends Adapter
6161
@zulip.on 'message', (msg) =>
6262
return if msg.sender_email is @zulip.email
6363

64-
room = room_for_message(msg)
65-
author = @robot.brain.userForId msg.sender_email,
66-
name: msg.sender_full_name
67-
email_address: msg.sender_email
68-
author.room = room
64+
author = this._author_for_message(msg)
6965

7066
content = msg.content.replace(@mention_regex, '@$1')
7167
console.log(@mention_regex, content)
72-
68+
7369
message = new TextMessage author, content, msg.id
7470
console.log "Received", message
7571
@receive(message)
7672

73+
_author_for_message: (msg) ->
74+
author = @robot.brain.userForId msg.sender_email,
75+
name: msg.sender_full_name
76+
email_address: msg.sender_email
77+
# Work around github/hubot#670 by setting room separately. If we pass it
78+
# to userForId, it could delete the existing user from the brain.
79+
author.room = room_for_message(msg)
80+
author
81+
82+
7783
exports.use = (robot) ->
7884
new Zulip robot
7985

0 commit comments

Comments
 (0)