Write the device logical type on startup, not just on formation

Author: puddly

tests/test_application.py

@@ -231,6 +231,7 @@ def on_endpoint_deletion(req):
         NwkNvIds.CONCENTRATOR_RC,
         NwkNvIds.SRC_RTG_EXPIRY_TIME,
         NwkNvIds.NWK_CHILD_AGE_ENABLE,
+        NwkNvIds.LOGICAL_TYPE,
     ]:
         znp_server.reply_to(
             request=c.SYS.OSALNVWrite.Req(Id=nvid, Offset=0, partial=True),

zigpy_znp/zigbee/application.py

@@ -329,6 +329,11 @@ async def startup(self, auto_form=False):
         await self._znp.nvram_write(NwkNvIds.SRC_RTG_EXPIRY_TIME, t.uint8_t(255))
         await self._znp.nvram_write(NwkNvIds.NWK_CHILD_AGE_ENABLE, t.Bool(False))
 
+        # XXX: the undocumented `znpBasicCfg` request can do this
+        await self._znp.nvram_write(
+            NwkNvIds.LOGICAL_TYPE, t.DeviceLogicalType.Coordinator
+        )
+
         # Reset to make the above NVRAM writes take effect.
         # This also ensures any previously-started network joins don't continue.
         await self._reset()
@@ -481,11 +486,6 @@ async def form_network(self):
             NwkNvIds.STARTUP_OPTION, t.StartupOptions.ClearState
         )
 
-        # XXX: the undocumented `znpBasicCfg` request can do this
-        await self._znp.nvram_write(
-            NwkNvIds.LOGICAL_TYPE, t.DeviceLogicalType.Coordinator
-        )
-
         pan_id = self.config[conf.CONF_NWK][conf.CONF_NWK_PAN_ID]
         extended_pan_id = self.config[conf.CONF_NWK][conf.CONF_NWK_EXTENDED_PAN_ID]