net: Namespace network symbols to avoid conflicts with POSIX or libc #99169

jukkar · 2025-11-10T16:34:56Z

Rename network symbols i.e., add net_, NET_ or ZSOCK_ prefixes to those network symbols that can be found in POSIX or libc. This way we can avoid circular dependency issues.

Fixes #97050

jukkar · 2025-11-10T16:37:16Z

Initial work on namespacing the network APIs, this is WIP. Creating a draft in order to get some faster CI runs than what I can do locally.
fyi: @aescolar / @rlubos / @cfriedt / @carlescufi

jukkar · 2025-11-10T16:42:38Z

Instructions for the reviewers. The main changes are in

include/zephyr/net/net_ip.h
include/zephyr/net/socket.h

The majority of the other changes are just to there to support the API naming changes.
The compatibility commit introduces a header file include/zephyr/net/net_compat.h that reverts the API changes so that we can do things in stages. This is controlled by a Kconfig option CONFIG_NET_NAMESPACE_COMPAT_MODE.

cfriedt

Good work so far. I just left a couple of comments for non-sockaddr things. Although I'm sure you are already aware and planning for those too.

cfriedt · 2025-11-10T17:45:53Z

doc/connectivity/networking/api/coap_server.rst


    static int send_temperature(struct coap_resource *resource,
-                                const struct sockaddr *addr, socklen_t addr_len,
+                                const struct net_sockaddr *addr, socklen_t addr_len,


socklen_t should probably also be changed to uint32_t within the network subsystem.

I did not go that route, but just changed socklen_t to net_socklen_t. Not sure if we should do that uint32_t change as now it is easy to map the socklen variable between the network and Posix apis (because the naming is similar).
What other reviewers think about this, I am open to replace net_socklen_t if there are good arguments for it.

cfriedt · 2025-11-10T17:47:43Z

drivers/bluetooth/hci/userchan_bottom.c

 	addr.hci_channel = HCI_CHANNEL_USER;

-	if (bind(fd, (struct sockaddr *)&addr, sizeof(addr)) < 0) {
+	if (bind(fd, (struct net_sockaddr *)&addr, sizeof(addr)) < 0) {


Calls to bind() should also be replaced with zsock_bind() (unless being used via POSIX through a sample).

Similarly, connect(), close(), should be switched to zsock_connect(), zsock_close(), etc.

That file is for native_sim driver so I think I need to remove all the changes I did there.

cfriedt · 2025-11-10T17:50:26Z

drivers/bluetooth/hci/userchan_bottom.c

 	}

-	if (connect(fd, (struct sockaddr *)&addr, sizeof(addr)) < 0) {
+	if (connect(fd, (struct net_sockaddr *)&addr, sizeof(addr)) < 0) {


This should use zsock_connect()

cfriedt · 2025-11-10T17:51:09Z

drivers/ethernet/intel/eth_intel_igc.c

 {
 	struct net_eth_hdr *eth_hdr = (struct net_eth_hdr *)rx_buf;

 	switch (ntohs(eth_hdr->type)) {


we should have a non-POSIX version of ntohs() and others too.

Yes, I will change these. I started to change the source all over the code base but there was just so much of it, so I decided to concentrate my efforts first to subsys/net, tests/net and include/zephyr/net directories. Some of the drivers contain already changes and I will continue this work.

drivers/usb/device/usb_dc_native_posix_adapt.c

aescolar

Thanks @jukkar , overall it is looking good to me :)

include/zephyr/net/net_compat.h

lib/posix/options/net.c

Rename network symbols in modem drivers to use the renamed network APIs. Signed-off-by: Jukka Rissanen <jukka.rissanen@nordicsemi.no>

Rename network symbols in usb drivers to use the renamed network APIs. Signed-off-by: Jukka Rissanen <jukka.rissanen@nordicsemi.no>

Rename network symbols in wifi drivers to use the renamed network APIs. Signed-off-by: Jukka Rissanen <jukka.rissanen@nordicsemi.no>

Removing Posix header inclusion as networking APIs and code should be self contained now. Signed-off-by: Jukka Rissanen <jukka.rissanen@nordicsemi.no>

Do not include Posix header files inside network stack as we should not depend on Posix symbols in net stack. Signed-off-by: Jukka Rissanen <jukka.rissanen@nordicsemi.no>

Use namespaced network symbols in order to avoid circular dependency between Posix and network subsystems. Signed-off-by: Jukka Rissanen <jukka.rissanen@nordicsemi.no>

We need certain network related Posix header files so that the network sample compiles ok. Previously the Posix symbols were introduced by network stack automatically even if user had not enabled Posix, but that is no longer the case. Signed-off-by: Jukka Rissanen <jukka.rissanen@nordicsemi.no>

We need certain network related Posix header files so that the network tests using Posix symbols compiles ok. Previously the Posix symbols were introduced by network stack automatically, but that is no longer the case. Signed-off-by: Jukka Rissanen <jukka.rissanen@nordicsemi.no>

Mark the err variable as possibly unsed depending on the enabled config options. Signed-off-by: Jukka Rissanen <jukka.rissanen@nordicsemi.no>

Compliance checker complains TYPO_SPELLING: 'in in' may be misspelled - perhaps 'is in'? for code like this static struct net_sockaddr_in in_addr_my = { so change the variable to ipv4_addr_my. Similar change is done for IPv6 variables for consistency. Signed-off-by: Jukka Rissanen <jukka.rissanen@nordicsemi.no>

The network backend needs nothing from Posix so remove the dependency. Signed-off-by: Jukka Rissanen <jukka.rissanen@nordicsemi.no>

Make sure we test coap client/server, MQTT SN, telnet and logging network backend when testing all network options. Signed-off-by: Jukka Rissanen <jukka.rissanen@nordicsemi.no>

jukkar · 2025-11-17T15:59:09Z

compliance check fix

sonarqubecloud · 2025-11-17T16:18:17Z

Quality Gate passed

Issues
81 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
4.3% Duplication on New Code

See analysis details on SonarQube Cloud

jukkar · 2025-11-17T16:23:19Z

If CI fails or something requires me to send a new version, I will also add a commit adding a note to migration guide. Otherwise I will send the migration guide changes in a separate PR immediately after this is merged.

This commit aims to refactor the application code after network namespace symbols have been changed zephyrproject-rtos#99169 Signed-off-by: Cristian Bulacu <cristian.bulacu@nxp.com>

In this commit, `net_socket_service_register` is called when a platform module that has sockets is deinitialized, and it's socket/sockets are closed. This commit also handles a case when a module tries to join a multicast group and a subscription, from another module, is already present. Also, covered network namespace changes done in zephyrproject-rtos#99169 Signed-off-by: Cristian Bulacu <cristian.bulacu@nxp.com>

In this commit, `net_socket_service_register` is called when a platform module that has sockets is deinitialized, and it's socket/sockets are closed. This commit also handles a case when a module tries to join a multicast group and a subscription, from another module, is already present. Also, covered network namespace changes done in #99169 Signed-off-by: Cristian Bulacu <cristian.bulacu@nxp.com>

jukkar added the In progress For PRs: is work in progress and should not be merged yet. For issues: Is being worked on label Nov 10, 2025

cfriedt reviewed Nov 10, 2025

View reviewed changes

aescolar reviewed Nov 11, 2025

View reviewed changes

drivers/usb/device/usb_dc_native_posix_adapt.c Outdated Show resolved Hide resolved

aescolar reviewed Nov 11, 2025

View reviewed changes

include/zephyr/net/net_compat.h Outdated Show resolved Hide resolved

lib/posix/options/net.c Outdated Show resolved Hide resolved

jukkar force-pushed the devel/97050/net-namespacing branch 9 times, most recently from 4a5aa36 to 1f46999 Compare November 13, 2025 11:51

jukkar removed the In progress For PRs: is work in progress and should not be merged yet. For issues: Is being worked on label Nov 13, 2025

jukkar marked this pull request as ready for review November 13, 2025 12:32

zephyrbot requested review from ClaCodes, Kludentwo, MaochenWang1, decsny, krish2718, lmajewski, maass-hamburg, matt-rodgers, pdgendt, rerickson1, rlubos and ssharks November 13, 2025 12:36

zephyrbot assigned rlubos Nov 13, 2025

jukkar added 12 commits November 17, 2025 17:57

net: Convert modem drivers to use renamed network APIs

9582e4b

Rename network symbols in modem drivers to use the renamed network APIs. Signed-off-by: Jukka Rissanen <jukka.rissanen@nordicsemi.no>

net: Convert usb drivers to use renamed network APIs

70c7300

Rename network symbols in usb drivers to use the renamed network APIs. Signed-off-by: Jukka Rissanen <jukka.rissanen@nordicsemi.no>

net: Convert wifi drivers to use renamed network APIs

65cddf3

Rename network symbols in wifi drivers to use the renamed network APIs. Signed-off-by: Jukka Rissanen <jukka.rissanen@nordicsemi.no>

net: socket: Network should not include any Posix header

48b1daa

Removing Posix header inclusion as networking APIs and code should be self contained now. Signed-off-by: Jukka Rissanen <jukka.rissanen@nordicsemi.no>

net: sockets: Remove Posix header file includes

990aaed

Do not include Posix header files inside network stack as we should not depend on Posix symbols in net stack. Signed-off-by: Jukka Rissanen <jukka.rissanen@nordicsemi.no>

lib: posix: net: Add support for namespaced network symbols

6f1d291

Use namespaced network symbols in order to avoid circular dependency between Posix and network subsystems. Signed-off-by: Jukka Rissanen <jukka.rissanen@nordicsemi.no>

tests: net: socket: tls_configurations: err variable might be unused

a0c87ad

Mark the err variable as possibly unsed depending on the enabled config options. Signed-off-by: Jukka Rissanen <jukka.rissanen@nordicsemi.no>

log: backend: net: Remove Posix dependency

6b7d121

The network backend needs nothing from Posix so remove the dependency. Signed-off-by: Jukka Rissanen <jukka.rissanen@nordicsemi.no>

tests: net: all: Add more compilation support

eea9c41

Make sure we test coap client/server, MQTT SN, telnet and logging network backend when testing all network options. Signed-off-by: Jukka Rissanen <jukka.rissanen@nordicsemi.no>

jukkar force-pushed the devel/97050/net-namespacing branch from cb7bee8 to eea9c41 Compare November 17, 2025 15:58

rlubos approved these changes Nov 17, 2025

View reviewed changes

pdgendt approved these changes Nov 17, 2025

View reviewed changes

jukkar changed the title ~~net: Namespace network symbols to avoid conflicts with Posix/libc~~ net: Namespace network symbols to avoid conflicts with POSIX or libc Nov 17, 2025

nashif merged commit 1380739 into zephyrproject-rtos:main Nov 17, 2025
33 checks passed

This was referenced Nov 18, 2025

Openthread border router fix socket close #99495

Merged

modules: openthread: Remove SOCK_NONBLOCK as it is not supported #99371

Closed

jukkar deleted the devel/97050/net-namespacing branch November 18, 2025 07:28

Cristib05 mentioned this pull request Nov 18, 2025

openthread: platform: Refactor after network namespace change #99567

Closed

jukkar mentioned this pull request Nov 18, 2025

Net namespace compatibility layer future work #99577

Open

aescolar mentioned this pull request Nov 19, 2025

Networking subsystem should not use extensions to the C library beyond the allowed subset #98212

Open

7 tasks

net: Namespace network symbols to avoid conflicts with POSIX or libc #99169

net: Namespace network symbols to avoid conflicts with POSIX or libc #99169

Uh oh!

Conversation

jukkar commented Nov 10, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

jukkar commented Nov 10, 2025

Uh oh!

jukkar commented Nov 10, 2025

Uh oh!

cfriedt left a comment

Choose a reason for hiding this comment

Uh oh!

cfriedt Nov 10, 2025

Choose a reason for hiding this comment

Uh oh!

jukkar Nov 11, 2025

Choose a reason for hiding this comment

Uh oh!

cfriedt Nov 10, 2025

Choose a reason for hiding this comment

Uh oh!

jukkar Nov 11, 2025

Choose a reason for hiding this comment

Uh oh!

cfriedt Nov 10, 2025

Choose a reason for hiding this comment

Uh oh!

cfriedt Nov 10, 2025

Choose a reason for hiding this comment

Uh oh!

jukkar Nov 11, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

aescolar left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

jukkar commented Nov 17, 2025

Uh oh!

sonarqubecloud bot commented Nov 17, 2025

Quality Gate passed

Uh oh!

jukkar commented Nov 17, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

jukkar commented Nov 10, 2025 •

edited

Loading

aescolar left a comment •

edited

Loading