drivers: video: Add Himax HM0360 camera sensor driver

[mjs513]

The camera supports grayscale in qqvga, qvga and vga resolutions. It has been tested on a arduino giga r1.

[sonarqubecloud]

Quality Gate passed

Issues
1 New issue
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
5.4% Duplication on New Code

See analysis details on SonarQube Cloud

[KurtE]

@mjs513 @NinoSc @josuah - Was just curious about what the status of the hm01b0(#94894) and hm0360 (this one).
Was looking to see which ones to try again to work with multiple cameras defined...

[josuah]

#94894 is only needing a 2nd review... but before some merge conflicts need to be addressed.

For this current PR, I just need to find a free slice of time as I'm pretty busy and late with work on USB lately.
I do take note that this is being slow, and wish to go back to this as soon as I get a chance!

Thanks for the patience, and apologies for such delay!

[mjs513]

@KurtE - @josuah

Since no one has looked at this yet I had some time from the OV7675 driver so I kind of redid the HM0360 with some lessons learned (probably still have indent issues) and also updated it to use the video cci commands. Figured that would be a better way to go.

Mike

[josuah]

Thank you for this driver!

I have added a few comments, I hope you find them relevant.

You might also want to look at this PR which has already been reviewed, but not yet merged, still could bring some illustrations of how to use the newest video APIs:

https://github.com/zephyrproject-rtos/zephyr/pull/94894/files

[KurtE]

Sorry I know side comment:

For those cases where I am using HM0360_REG8 I added in CCI like the HM01b0 driver (still open) did.

Wondering if he will finish the HM01b0 or should someone submit a new one?

[josuah]

Wondering if he will finish the HM01b0 or should someone submit a new one?

The sensor is complete and has passed review and now just need some rebase and then getting merged.

• drivers: video: Himax HM01B0 camera sensor driver #94894

Or did you spot missing settings you wanted to also add to it?

[KurtE]

Wondering if he will finish the HM01b0 or should someone submit a new one?
Or did you spot missing settings you wanted to also add to it?
Sorry I know it is mostly off topic here, Although some of it could apply here as well.
Most of these was/am planning a follow on PR to address, including:

a) Resolutions are wrong: when you ask for 320x320 it actually returns something like 324x324 ditto for 320x240
Probably 1b0 specific.

b) 1b0 has setting for data-bits: which can be 1,4,8 I believe 360 support 4,8? Not sure about 1. How should this be
handled? That is if I choose 4 bit (Arducam/Arduino devices are wired for 4), how does the video drivers such as
DCMI handle this? That is for each logical byte, the camera will return two bytes... I had a hacked up version that
gave special type like RGB565_4 and doubled buffer, but instead should be some communication between drivers,
and who is responsible for putting the bytes back together? User code, STM32_DCMI (and others?) ..

c) Color, supports color: probably needs new things added to types table: VIDEO_PIX_FMT_SBGGR8 (Bayer)
#95963 Not sure if any HM0360 sold with Bayer? I have the Sparkfun color HM01b0

Sorry I know this is mostly off topic here.

[mjs513]

@josuah

I have added a few comments, I hope you find them relevant.

You might also want to look at this PR which has already been reviewed, but not yet merged, still could bring some illustrations of how to use the newest video APIs:

Thanks for the review if I didn't say it earlier.

But not sure what you mean about the newest video API;s ... But I do see where you had me incorporate s/w changes that were similar :)

Going to push changes as separate commit so you can see the changes from one to the other - or would you prefer I squash them into one.

Thanks Mike

[mjs513]

@KurtE - @josuah

1b0 has setting for data-bits: which can be 1,4,8 I believe 360 support 4,8? Not sure about 1.
Looking at the spec the 360 can support all 3 - 1, 4, 8 bit.

Color, supports color: probably needs new things added to types table: VIDEO_PIX_FMT_SBGGR8 (Bayer)
#95963 Not sure if any HM0360 sold with Bayer? I have the Sparkfun color HM01b0

The arducam HM0360 that I have been using only support greyscale / monochrome - the color version will support bayer accoding to the spec. We ran into this when we were testing with the Teensy.

EDIT: Think will try Bayer as an experiment

[avolmat-st]

Thanks for the patch.

In addition to other inline comments, could you also fix the commit message, it currently have twice the same line:

drivers: video Add Himax HM0360 camera sensor driver

[mjs513]

@avolmat-st - @josuah
Pushed the desired updates however there are still 2 issues to be resolved so I left the open

[mjs513]

@josuah
Just saw your message to @KurtE about doing a rebase to clear up documenation issues - so did that for the HM0360 since it was showing the same documentation build error.

[avolmat-st]

Thanks for the update. Make 3 comments above in reply to previous points:

#94904 (comment)

#94904 (comment)

#94904 (comment)

2 optional, 1 blocking (set_fmt function return value checking)

[mjs513]

@avolmat-st

Thanks for the update. Make 3 comments above in reply to previous points:

#94904 (comment)

#94904 (comment)

#94904 (comment)

2 optional, 1 blocking (set_fmt function return value checking)

Ok - all changes incorporated

[avolmat-st]

Thanks for the update. Sorry, added 3 comments but really apart from that it is all good to me.

[mjs513]

@avolmat-st

Thanks for the update. Sorry, added 3 comments but really apart from that it is all good to me.

Pushed the changes and no problem. Easy ones.

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

[avolmat-st]

Thanks a lot, all ok.

[ngphibang]

LGTM. Thanks for the work !

[github-actions]

Hi @mjs513!
Congratulations on getting your very first Zephyr pull request merged 🎉🥳. This is a fantastic achievement, and we're thrilled to have you as part of our community!

To celebrate this milestone and showcase your contribution, we'd love to award you the Zephyr Technical Contributor badge. If you're interested, please claim your badge by filling out this form: Claim Your Zephyr Badge.

Thank you for your valuable input, and we look forward to seeing more of your contributions in the future! 🪁