Skip to content

Commit 909373f

Browse files
committed
scripts: set_assignee: get area object before before collabs
In the manifest case, we were operating on a str instead of the area object. Signed-off-by: Anas Nashif <anas.nashif@intel.com>
1 parent 4a0e6d4 commit 909373f

File tree

1 file changed

+3
-1
lines changed

1 file changed

+3
-1
lines changed

scripts/ci/set_assignees.py

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -248,9 +248,11 @@ def process_pr(gh, maintainer_file, number):
248248
continue
249249
parsed_areas = process_manifest(old_manifest_file=args.updated_manifest)
250250
for _area in parsed_areas:
251-
collab_per_path.update(_area.get_collaborators_for_path(changed_file.filename))
252251
area_match = maintainer_file.name2areas(_area)
253252
if area_match:
253+
_area_obj = area_match[0]
254+
collabs_for_area = _area_obj.get_collaborators_for_path(changed_file.filename)
255+
collab_per_path.update(collabs_for_area)
254256
areas.extend(area_match)
255257
elif changed_file.filename in ['MAINTAINERS.yml']:
256258
areas = maintainer_file.path2areas(changed_file.filename)

0 commit comments

Comments
 (0)