From 06c0c4bbad3385d836d60dd75283025ada2bcbb9 Mon Sep 17 00:00:00 2001 From: Dimitri Papadopoulos <3234522+DimitriPapadopoulos@users.noreply.github.com> Date: Sun, 12 Apr 2026 09:57:55 +0200 Subject: [PATCH 1/3] chore: update pre-commit hook sp-repo-review MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit updates: - github.com/scientific-python/cookie: 2025.05.02 → 2026.04.04 enables a couple ingonred rules: - PY005: Has tests folder - PY006: Has pre-commit config - RF103: pyupgrade must be selected --- .pre-commit-config.yaml | 2 +- pyproject.toml | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/.pre-commit-config.yaml b/.pre-commit-config.yaml index 59c2c983..292ad278 100644 --- a/.pre-commit-config.yaml +++ b/.pre-commit-config.yaml @@ -21,7 +21,7 @@ repos: - id: ruff-format - repo: https://github.com/scientific-python/cookie - rev: 2025.05.02 + rev: 2026.04.04 hooks: - id: sp-repo-review diff --git a/pyproject.toml b/pyproject.toml index 878c912a..2f50fac3 100644 --- a/pyproject.toml +++ b/pyproject.toml @@ -122,7 +122,7 @@ exclude_lines = [ ] [tool.repo-review] -ignore = ["PY005", "PY007", "PP302", "PP308", "PP309", "GH103", "GH212", "PC111", "PC140", "PC160", "PC170", "PC180", "MY100", "RF103"] +ignore = ["PY007", "PP302", "PP308", "PP309", "GH103", "GH212", "PC111", "PC140", "PC160", "PC170", "PC180", "MY100"] [tool.pytest.ini_options] addopts = "-ra --strict-config --strict-markers --cov=numcodecs --cov-report xml --doctest-modules --doctest-glob=*.pyx" From 88bc65598235165ef17227c8ce27766315dd446b Mon Sep 17 00:00:00 2001 From: Dimitri Papadopoulos <3234522+DimitriPapadopoulos@users.noreply.github.com> Date: Sun, 12 Apr 2026 09:58:44 +0200 Subject: [PATCH 2/3] Apply cookie rule PP304 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit PyProject: └── PP304 Sets the log level in pytest ❌ log_level should be set. This will allow logs to be displayed on failures. --- pyproject.toml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/pyproject.toml b/pyproject.toml index 2f50fac3..068602cd 100644 --- a/pyproject.toml +++ b/pyproject.toml @@ -125,7 +125,7 @@ exclude_lines = [ ignore = ["PY007", "PP302", "PP308", "PP309", "GH103", "GH212", "PC111", "PC140", "PC160", "PC170", "PC180", "MY100"] [tool.pytest.ini_options] -addopts = "-ra --strict-config --strict-markers --cov=numcodecs --cov-report xml --doctest-modules --doctest-glob=*.pyx" +addopts = ["-ra", "--strict-config", "--strict-markers", "--cov=numcodecs", "--cov-report", "xml", "--doctest-modules", "--doctest-glob=*.pyx"] doctest_optionflags = [ "NORMALIZE_WHITESPACE", "ELLIPSIS", @@ -148,7 +148,7 @@ norecursedirs = [ "notebooks", "numcodecs.egg-info", ] -log_cli_level = "INFO" +log_level = "INFO" xfail_strict = true filterwarnings = [ "error", From c2e315a7388caeca4ae30667bc9655b4931c6430 Mon Sep 17 00:00:00 2001 From: Dimitri Papadopoulos <3234522+DimitriPapadopoulos@users.noreply.github.com> Date: Sun, 12 Apr 2026 10:10:19 +0200 Subject: [PATCH 3/3] Temporarily ignore cookie rule GH105 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit GitHub Actions: └── GH105 Use Trusted Publishing instead of token-based publishing on PyPI ❌ --- pyproject.toml | 16 +++++++++++++++- 1 file changed, 15 insertions(+), 1 deletion(-) diff --git a/pyproject.toml b/pyproject.toml index 068602cd..8d5bcd23 100644 --- a/pyproject.toml +++ b/pyproject.toml @@ -122,7 +122,21 @@ exclude_lines = [ ] [tool.repo-review] -ignore = ["PY007", "PP302", "PP308", "PP309", "GH103", "GH212", "PC111", "PC140", "PC160", "PC170", "PC180", "MY100"] +ignore = [ + "PY007", + "PP302", + "PP308", + "PP309", + "GH103", + "GH105", # https://github.com/zarr-developers/zarr-python/issues/3798 + "GH212", + "MY100", + "PC111", + "PC140", + "PC160", + "PC170", + "PC180", +] [tool.pytest.ini_options] addopts = ["-ra", "--strict-config", "--strict-markers", "--cov=numcodecs", "--cov-report", "xml", "--doctest-modules", "--doctest-glob=*.pyx"]