Remove AutoClosable from YdbSchemaOperations (#172)

Now YdbSchemaOperations is just a thin wrapper, and all API clients are managed by the owning YdbRepository.

Co-authored-by: Alexander Lavrukov <lavrukov@yandex-team.ru>

Author: lavrukov

repository-ydb-v2/src/main/java/tech/ydb/yoj/repository/ydb/YdbRepository.java

@@ -15,8 +15,10 @@
 import tech.ydb.core.grpc.GrpcTransportBuilder;
 import tech.ydb.core.impl.SingleChannelTransport;
 import tech.ydb.core.impl.auth.GrpcAuthRpc;
+import tech.ydb.scheme.SchemeClient;
 import tech.ydb.table.SessionPoolStats;
 import tech.ydb.table.TableClient;
+import tech.ydb.topic.TopicClient;
 import tech.ydb.yoj.repository.db.Entity;
 import tech.ydb.yoj.repository.db.EntitySchema;
 import tech.ydb.yoj.repository.db.Repository;
@@ -355,18 +357,26 @@ public record Settings(
 
     private static final class SessionClient implements AutoCloseable {
         private final TableClient tableClient;
+        private final SchemeClient schemeClient;
+        private final TopicClient topicClient;
+
         private final SessionManager sessionManager;
         private final YdbSchemaOperations schemaOperations;
 
         private SessionClient(YdbConfig config, Settings repositorySettings, GrpcTransport transport) {
             this.tableClient = createClient(config, repositorySettings, transport);
+            this.schemeClient = SchemeClient.newClient(transport).build();
+            this.topicClient = TopicClient.newClient(transport).build();
+
             this.sessionManager = new YdbSessionManager(tableClient, config.getSessionCreationTimeout());
-            this.schemaOperations = new YdbSchemaOperations(config.getTablespace(), this.sessionManager, transport);
+            this.schemaOperations = new YdbSchemaOperations(
+                    config.getTablespace(), sessionManager, schemeClient, topicClient
+            );
         }
 
         @Override
         public void close() {
-            Exceptions.closeAll(tableClient, schemaOperations);
+            Exceptions.closeAll(tableClient, schemeClient, topicClient);
         }
     }
 

repository-ydb-v2/src/main/java/tech/ydb/yoj/repository/ydb/client/YdbSchemaOperations.java

@@ -10,7 +10,6 @@
 import org.slf4j.LoggerFactory;
 import tech.ydb.core.Result;
 import tech.ydb.core.Status;
-import tech.ydb.core.grpc.GrpcTransport;
 import tech.ydb.proto.ValueProtos;
 import tech.ydb.scheme.SchemeClient;
 import tech.ydb.scheme.description.DescribePathResult;
@@ -42,7 +41,6 @@
 import tech.ydb.yoj.repository.ydb.exception.YdbSchemaPathNotFoundException;
 import tech.ydb.yoj.repository.ydb.yql.YqlPrimitiveType;
 import tech.ydb.yoj.repository.ydb.yql.YqlType;
-import tech.ydb.yoj.util.lang.Exceptions;
 
 import java.util.ArrayList;
 import java.util.List;
@@ -58,21 +56,26 @@
 import static lombok.AccessLevel.PRIVATE;
 import static tech.ydb.core.StatusCode.SCHEME_ERROR;
 
-@Getter
 @InternalApi
-public final class YdbSchemaOperations implements AutoCloseable {
+public final class YdbSchemaOperations {
     private static final Logger log = LoggerFactory.getLogger(YdbSchemaOperations.class);
 
+    @Getter
+    private String tablespace;
     private final SessionManager sessionManager;
     private final SchemeClient schemeClient;
     private final TopicClient topicClient;
-    private String tablespace;
 
-    public YdbSchemaOperations(String tablespace, @NonNull SessionManager sessionManager, GrpcTransport transport) {
+    public YdbSchemaOperations(
+            String tablespace,
+            SessionManager sessionManager,
+            SchemeClient schemeClient,
+            TopicClient topicClient
+    ) {
         this.tablespace = YdbPaths.canonicalTablespace(tablespace);
         this.sessionManager = sessionManager;
-        this.schemeClient = SchemeClient.newClient(transport).build();
-        this.topicClient = TopicClient.newClient(transport).build();
+        this.schemeClient = schemeClient;
+        this.topicClient = topicClient;
     }
 
     public void setTablespace(String tablespace) {
@@ -476,11 +479,6 @@ public boolean hasPath(String path) {
         throw new YdbRepositoryException("Can't describe table '" + path + "': " + result);
     }
 
-    @Override
-    public void close() {
-        Exceptions.closeAll(topicClient, schemeClient);
-    }
-
     @Value
     private static class DirectoryEntity {
         EntryType type;