Skip to content

Commit 9b7cddb

Browse files
committed
Remove bytes counters, fix issues returning and logs for BATCH operations (#28853)
1 parent 3c28b5a commit 9b7cddb

File tree

4 files changed

+169
-139
lines changed

4 files changed

+169
-139
lines changed

ydb/core/kqp/counters/kqp_counters.cpp

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -896,11 +896,7 @@ TKqpCounters::TKqpCounters(const ::NMonitoring::TDynamicCounterPtr& counters, co
896896

897897
/* Statistics batch operations */
898898
BatchOperationUpdateRows = KqpGroup->GetCounter("BatchOperation/Update/Rows", true);
899-
BatchOperationUpdateBytes = KqpGroup->GetCounter("BatchOperation/Update/Bytes", true);
900-
901899
BatchOperationDeleteRows = KqpGroup->GetCounter("BatchOperation/Delete/Rows", true);
902-
BatchOperationDeleteBytes = KqpGroup->GetCounter("BatchOperation/Delete/Bytes", true);
903-
904900
BatchOperationRetries = KqpGroup->GetCounter("BatchOperation/Retries", true);
905901
}
906902

ydb/core/kqp/counters/kqp_counters.h

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -487,9 +487,7 @@ class TKqpCounters : public TKqpCountersBase, public NYql::NDq::TSpillingCounter
487487

488488
// Statistics batch operations
489489
::NMonitoring::TDynamicCounters::TCounterPtr BatchOperationUpdateRows;
490-
::NMonitoring::TDynamicCounters::TCounterPtr BatchOperationUpdateBytes;
491490
::NMonitoring::TDynamicCounters::TCounterPtr BatchOperationDeleteRows;
492-
::NMonitoring::TDynamicCounters::TCounterPtr BatchOperationDeleteBytes;
493491
::NMonitoring::TDynamicCounters::TCounterPtr BatchOperationRetries;
494492
};
495493

ydb/core/kqp/executer_actor/kqp_executer_impl.h

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -2175,10 +2175,7 @@ class TKqpExecuterBase : public TActor<TDerived> {
21752175
if (!BatchOperationSettings.Empty() && !Stats->TableStats.empty()) {
21762176
auto [_, tableStats] = *Stats->TableStats.begin();
21772177
Counters->Counters->BatchOperationUpdateRows->Add(tableStats->GetWriteRows());
2178-
Counters->Counters->BatchOperationUpdateBytes->Add(tableStats->GetWriteBytes());
2179-
21802178
Counters->Counters->BatchOperationDeleteRows->Add(tableStats->GetEraseRows());
2181-
Counters->Counters->BatchOperationDeleteBytes->Add(tableStats->GetEraseBytes());
21822179
}
21832180

21842181
auto finishSize = Stats->EstimateFinishMem();

0 commit comments

Comments
 (0)