Fix YqlParser: unitialized variables and ignoring BuildType return value (#29184)

Author: pnv1

ydb/public/lib/ydb_cli/common/yql_parser/yql_parser.cpp

@@ -44,11 +44,11 @@ class TYqlTypeParser {
 
 private:
     struct TypeNode {
-        TTypeParser::ETypeKind TypeKind;
+        std::optional<TTypeParser::ETypeKind> TypeKind = std::nullopt;
         std::vector<TypeNode> Children;
 
         // For primitive type
-        EPrimitiveType PrimitiveType;
+        std::optional<EPrimitiveType> PrimitiveType = std::nullopt;
 
         // For struct type
         TString Name;
@@ -218,14 +218,6 @@ class TYqlTypeParser {
             node.PrimitiveType = EPrimitiveType::JsonDocument;
         } else if (content == "dynumber") {
             node.PrimitiveType = EPrimitiveType::DyNumber;
-        } else if (content == "emptylist") {
-            node.TypeKind = TTypeParser::ETypeKind::EmptyList;
-        } else if (content == "emptydict") {
-            node.TypeKind = TTypeParser::ETypeKind::EmptyDict;
-        } else if (content == "void") {
-            node.TypeKind = TTypeParser::ETypeKind::Void;
-        } else if (content == "null") {
-            node.TypeKind = TTypeParser::ETypeKind::Null;
         } else {
             return std::nullopt;
         }
@@ -273,39 +265,58 @@ class TYqlTypeParser {
     }
 
     bool BuildType(const TypeNode& node, TTypeBuilder& builder) {
-        if (node.TypeKind == TTypeParser::ETypeKind::Optional) {
+        if (!node.TypeKind.has_value()) {
+            return false;
+        }
+
+        if (*node.TypeKind == TTypeParser::ETypeKind::Optional) {
             builder.BeginOptional();
-            BuildType(node.Children[0], builder);
+            if (!BuildType(node.Children[0], builder)) {
+                return false;
+            }
             builder.EndOptional();
-        } else if (node.TypeKind == TTypeParser::ETypeKind::List) {
+        } else if (*node.TypeKind == TTypeParser::ETypeKind::List) {
             builder.BeginList();
-            BuildType(node.Children[0], builder);
+            if (!BuildType(node.Children[0], builder)) {
+                return false;
+            }
             builder.EndList();
-        } else if (node.TypeKind == TTypeParser::ETypeKind::Struct) {
+        } else if (*node.TypeKind == TTypeParser::ETypeKind::Struct) {
             builder.BeginStruct();
             for (const auto& field : node.Children) {
                 builder.AddMember(field.Name);
-                BuildType(field, builder);
+                if (!BuildType(field, builder)) {
+                    return false;
+                }
             }
             builder.EndStruct();
-        } else if (node.TypeKind == TTypeParser::ETypeKind::Tuple) {
+        } else if (*node.TypeKind == TTypeParser::ETypeKind::Tuple) {
             builder.BeginTuple();
             for (const auto& element : node.Children) {
                 builder.AddElement();
-                BuildType(element, builder);
+                if (!BuildType(element, builder)) {
+                    return false;
+                }
             }
             builder.EndTuple();
-        } else if (node.TypeKind == TTypeParser::ETypeKind::Dict) {
+        } else if (*node.TypeKind == TTypeParser::ETypeKind::Dict) {
             builder.BeginDict();
             builder.DictKey();
-            BuildType(node.Children[0], builder);
+            if (!BuildType(node.Children[0], builder)) {
+                return false;
+            }
             builder.DictPayload();
-            BuildType(node.Children[1], builder);
+            if (!BuildType(node.Children[1], builder)) {
+                return false;
+            }
             builder.EndDict();
-        } else if (node.TypeKind == TTypeParser::ETypeKind::Decimal) {
+        } else if (*node.TypeKind == TTypeParser::ETypeKind::Decimal) {
             builder.Decimal(TDecimalType(node.precision, node.scale));
-        } else if (node.TypeKind == TTypeParser::ETypeKind::Primitive) {
-            builder.Primitive(node.PrimitiveType);
+        } else if (*node.TypeKind == TTypeParser::ETypeKind::Primitive) {
+            if (!node.PrimitiveType.has_value()) {
+                return false;
+            }
+            builder.Primitive(*node.PrimitiveType);
         } else {
             return false;
         }