From 1c5efcab552bc43de6f0b2260108c6ac847ba7f4 Mon Sep 17 00:00:00 2001 From: "github-actions[bot]" Date: Fri, 3 Jul 2026 01:30:42 +0000 Subject: [PATCH 1/2] docs: update changelog for PR #51 --- CHANGELOG.md | 33 +++++++++++++++++++++++++++++++++ 1 file changed, 33 insertions(+) diff --git a/CHANGELOG.md b/CHANGELOG.md index 4e662e35..bb8e4c9e 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -7,6 +7,39 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0 ## [Unreleased](https://github.com/yCodeTech/valet-windows/tree/master) +### Fixed + +- Fixed ngrok error logging by adding real-time output ([#51](https://github.com/yCodeTech/valet-windows/pull/51)) by @yCodeTech + + Technically a follow-up to issue #48 that prompted me to double check ngrok was running properly; and also a follow-up and enhancement of commit 2724314 + + It was really hard to figure out if there was something wrong with ngrok without proper logging. Ngrok does actually have an undocumented `--log` option for the `http` command (but documented as [API flags](https://ngrok.com/docs/agent/cli-api#flags-2)), so we can use this to stream live logging output directly to the terminal. + + **Summary** + + This pull request introduces significant improvements to the ngrok sharing experience in Valet, including real-time logging, automatic copying of the public URL to the clipboard, and a more robust streaming of ngrok output. It also updates documentation to reflect these changes and includes some minor codebase improvements. + + **Enhancements to ngrok sharing and output handling:** + + - Added a new `streamCommandOutput` method in `CommandLine.php` to stream command output in real-time, with support for error detection, line handling, and formatting errors as valet errors. + - Updated `Ngrok.php` to: + - Set default ngrok options for real-time logging (`log=stdout`, `log-level=info`, `log-format=term`), with ability for users to override these settings or completely disable the real-time logging. + - Stream ngrok output in real-time, detect and display the public URL when available (formatted as an information output), and copy it to the clipboard automatically. + - Inform the user how to fetch the public URL if real-time logging is disabled. + + **Clipboard improvements:** + + - Refactored URL copying logic into a reusable `copyUrlToClipboard` method in `ShareTool.php`, ensuring consistent and secure clipboard operations. + - Removed redundant clipboard message in `valet.php` since the new method handles user notification. + + **Error and output handling:** + + - Enhanced the `error` and `output` helper functions to improve formatting and robustness. + - Changing the usage of Symfony's `writeln` to `write` to support optional writing of newlines at the end of the output. + - Included the Symfony `OutputFormatter` for output escaping in the `error` helper function. + + + ## [3.4.3](https://github.com/yCodeTech/valet-windows/tree/v3.4.3) - 2026-06-08 ### Fixed From e7e4290731d00f2428f2bc708c07d18aad27a413 Mon Sep 17 00:00:00 2001 From: "github-actions[bot]" Date: Fri, 3 Jul 2026 02:18:27 +0000 Subject: [PATCH 2/2] docs: update changelog for PR #49 --- CHANGELOG.md | 34 ++++++++++++++++++++++++++++++++++ 1 file changed, 34 insertions(+) diff --git a/CHANGELOG.md b/CHANGELOG.md index bb8e4c9e..957d06af 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -40,6 +40,40 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0 +### Changed + +- Refactored update error pages ([#49](https://github.com/yCodeTech/valet-windows/pull/49)) by @yCodeTech + + This pull request updates the `404.html` and `500.html` error page templates to improve their appearance, responsiveness, and maintainability. The changes focus on improving layout, using modern CSS, enhancing mobile support, and unify the branding and SVG usage across both pages. + + **HTML Structure, UX, and Responsiveness Improvements:** + + - Consolidated SVG styles into the main `