Skip to content

v0.2.5 skin is broken #38

@jbusecke

Description

@jbusecke

Sorry for the oversight. The fact that tests show as passed in the CI while they fail in the fortran code is really dicey. We (I especially since that has happened multiple times to me at this point) have to check each of the CI actions and confirm that pytest actually completed the test and did not crash.

Back to the problem at hand though. Unfortunately in #34 I forgot to reactivate the test for the skin xarray wrapper, which lead to an actually passing CI! I noticed the missing test parametrization in #35, but missed that the tests did not pass.

So it seems that threadsafe somehow broke the skin but not the noskin method but only in the case of certain chunking schemes. Very weird, ill investigate now.

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't working

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions