Fix Rubocop violations #494
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crazytonyli
approved these changes
Jun 15, 2023
Contributor
crazytonyli
left a comment
crazytonyli
left a comment
There was a problem hiding this comment.
I trust Rubocop made the right auto-correct changes. And the name changes looks good to me too.
iangmaia
approved these changes
Jun 15, 2023
Contributor
iangmaia
left a comment
iangmaia
left a comment
There was a problem hiding this comment.
Nice one, @spencertransier 👍
LGTM. I'll wait for this one to land before I finally merge #489 to avoid conflicts on your side, so that I can also update the code according to the updated rules over there.
Contributor
Author
|
Thanks @iangmaia. Sounds good, I'm excited to have your PR merged! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does it do?
.rubocop_todo.yml. I went through and removed a section from the todo file, ran Rubocop, then fixed any of the issues it found..rubocop_todo.ymlto get the latest status by runningbundle exec rubocop --regenerate-todoNaming/VariableNamechanges, I verified that those variables are only used internally by those actions and are not breaking changes for clients.Checklist before requesting a review
bundle exec rubocopto test for code style violations and recommendationsspecs/*_spec.rb) if applicablebundle exec rspecto run the whole test suite and ensure all your tests passCHANGELOG.mdfile to describe your changes under the appropriate existing###subsection of the existing## Trunksection.MIGRATION.mdfile to describe how the changes will affect the migration from the previous major version and what the clients will need to change and consider.