Merge pull request #344 from wordpress-mobile/l10n/log-message-improvements

Improve some log messages on L10n-related actions

Author: AliSoftware

CHANGELOG.md

@@ -14,7 +14,7 @@ _None_
 
 ### Bug Fixes
 
-_None_
+* Improved logs and console output, to avoid `ios_download_strings_files_from_glotpress` to look like it's deadlocked while it takes some time to download all the exports of all the locales, and to avoid the log messages from `ios_extract_keys_from_strings_files` to be misleading. [#344]
 
 ### Internal Changes
 

lib/fastlane/plugin/wpmreleasetoolkit/actions/ios/ios_download_strings_files_from_glotpress.rb

@@ -10,6 +10,7 @@ def self.run(params)
 
         locales.each do |glotpress_locale, lproj_name|
           # Download the export in the proper `.lproj` directory
+          UI.message "Downloading translations for '#{lproj_name}' from GlotPress (#{glotpress_locale}) [#{params[:filters]}]..."
           lproj_dir = File.join(download_dir, "#{lproj_name}.lproj")
           destination = File.join(lproj_dir, "#{params[:table_basename]}.strings")
           FileUtils.mkdir(lproj_dir) unless Dir.exist?(lproj_dir)

lib/fastlane/plugin/wpmreleasetoolkit/actions/ios/ios_extract_keys_from_strings_files.rb

@@ -16,9 +16,9 @@ def self.run(params)
             next if target_strings_file == target_original_file # do not generate/overwrite the original locale itself
 
             keys_to_extract = keys_to_extract_per_target_file[target_original_file]
-            UI.message("Extracting #{keys_to_extract.count} keys into #{target_strings_file}...")
-
             extracted_translations = translations.slice(*keys_to_extract)
+            UI.message("Extracting #{extracted_translations.count} keys (out of #{keys_to_extract.count} expected) into #{target_strings_file}...")
+
             FileUtils.mkdir_p(File.dirname(target_strings_file)) # Ensure path up to parent dir exists, create it if not.
             Fastlane::Helper::Ios::L10nHelper.generate_strings_file_from_hash(translations: extracted_translations, output_path: target_strings_file)
           rescue StandardError => e