Fix a couple of bugs in managing terms (#24960)

* Fix deleting tag confirmation dialog location

Fixes https://linear.app/a8c/issue/CMM-877

* Hide empty view after adding a term

Fixes https://linear.app/a8c/issue/CMM-876

Author: crazytonyli

WordPress/Classes/ViewRelated/Tags/EditTagView.swift

@@ -54,12 +54,30 @@ struct EditTagView: View {
 
             if viewModel.isExistingTag {
                 Section {
-                    Button(action: {
+                    Button(role: .destructive) {
                         viewModel.showDeleteConfirmation = true
-                    }) {
+                    } label: {
                         Text(SharedStrings.Button.delete)
                             .foregroundColor(.red)
                     }
+                    .frame(maxWidth: .infinity)
+                }
+                .confirmationDialog(
+                    Strings.deleteConfirmationTitle,
+                    isPresented: $viewModel.showDeleteConfirmation,
+                    titleVisibility: .visible
+                ) {
+                    Button(SharedStrings.Button.delete, role: .destructive) {
+                        Task {
+                            let success = await viewModel.deleteTag()
+                            if success {
+                                dismiss()
+                            }
+                        }
+                    }
+                    Button(SharedStrings.Button.cancel, role: .cancel) { }
+                } message: {
+                    Text(Strings.deleteConfirmationMessage)
                 }
             }
         }
@@ -78,23 +96,6 @@ struct EditTagView: View {
                 .disabled(viewModel.tagName.trimmingCharacters(in: .whitespacesAndNewlines).isEmpty)
             }
         }
-        .confirmationDialog(
-            Strings.deleteConfirmationTitle,
-            isPresented: $viewModel.showDeleteConfirmation,
-            titleVisibility: .visible
-        ) {
-            Button(SharedStrings.Button.delete, role: .destructive) {
-                Task {
-                    let success = await viewModel.deleteTag()
-                    if success {
-                        dismiss()
-                    }
-                }
-            }
-            Button(SharedStrings.Button.cancel, role: .cancel) { }
-        } message: {
-            Text(Strings.deleteConfirmationMessage)
-        }
         .alert(SharedStrings.Error.generic, isPresented: $viewModel.showError) {
             Button(SharedStrings.Button.ok) { }
         } message: {

WordPress/Classes/ViewRelated/Tags/SiteTagsView.swift

@@ -55,13 +55,7 @@ private struct TagsListView: View {
         .listStyle(.plain)
         .overlay {
             if let response = viewModel.response {
-                if response.isEmpty {
-                    EmptyStateView(
-                        viewModel.labels.empty,
-                        systemImage: "tag",
-                        description: viewModel.labels.emptyDescription
-                    )
-                }
+                NoTermView(viewModel: viewModel, response: response)
             } else if viewModel.isLoading {
                 ProgressView()
             } else if let error = viewModel.error {
@@ -76,6 +70,21 @@ private struct TagsListView: View {
     }
 }
 
+private struct NoTermView: View {
+    @ObservedObject var viewModel: TagsViewModel
+    @ObservedObject var response: TagsPaginatedResponse
+
+    var body: some View {
+        if response.isEmpty {
+            EmptyStateView(
+                viewModel.labels.empty,
+                systemImage: "tag",
+                description: viewModel.labels.emptyDescription
+            )
+        }
+    }
+}
+
 private struct TagsSearchView: View {
     @ObservedObject var viewModel: TagsViewModel