From 58520ace10bb9f8467066d09c696aaf8a2c971f7 Mon Sep 17 00:00:00 2001 From: Eric Blankenhorn Date: Fri, 7 Aug 2026 14:11:45 -0500 Subject: [PATCH 1/2] Fix ML-DSA example in docs --- docs/asymmetric.rst | 8 ++++---- lib/wolfssl | 2 +- scripts/build_ffi.py | 4 +++- 3 files changed, 8 insertions(+), 6 deletions(-) diff --git a/docs/asymmetric.rst b/docs/asymmetric.rst index 886d47a..d121fd9 100644 --- a/docs/asymmetric.rst +++ b/docs/asymmetric.rst @@ -144,8 +144,8 @@ ML-DSA >>> >>> msg = b"This is an example message" >>> ->>> sig = mldsa_priv.sign(msg) ->>> mldsa_pub.verify(sig, msg) +>>> sig = mldsa_priv.sign(msg, ctx=b"") +>>> mldsa_pub.verify(sig, msg, ctx=b"") True >>> >>> ######## Export and Import Keys @@ -160,6 +160,6 @@ True >>> mldsa_pub2 = MlDsaPublic(mldsa_type) >>> mldsa_pub2.decode_key(exported_pub_key) >>> ->>> sig2 = mldsa_priv2.sign(msg) ->>> mldsa_pub2.verify(sig2, msg) +>>> sig2 = mldsa_priv2.sign(msg, ctx=b"") +>>> mldsa_pub2.verify(sig2, msg, ctx=b"") True \ No newline at end of file diff --git a/lib/wolfssl b/lib/wolfssl index ac01707..59f4fa5 160000 --- a/lib/wolfssl +++ b/lib/wolfssl @@ -1 +1 @@ -Subproject commit ac01707f552c611fbd135cc723b2682b3e7f80f2 +Subproject commit 59f4fa568615396fbf381b073b220d1e8d61e4c2 diff --git a/scripts/build_ffi.py b/scripts/build_ffi.py index 6807edf..411fc9f 100644 --- a/scripts/build_ffi.py +++ b/scripts/build_ffi.py @@ -235,7 +235,9 @@ def make_flags(prefix, fips): # ML-KEM flags.append("--enable-mlkem") - # ML-DSA (note: to be able to use the legacy option of signing without context, pass `yes,no-ctx` as argument) + # ML-DSA (note: to be able to use the legacy option of signing without context, pass `yes,draft` as + # argument -- wolfSSL has no `no-ctx` option; `draft` defines WOLFSSL_DILITHIUM_FIPS204_DRAFT, which + # also switches to the pre-FIPS-204 draft signature format) flags.append("--enable-mldsa=yes") # disabling other configs enabled by default From d4b8fbad0e89517cf592f368dfecd30048f942b1 Mon Sep 17 00:00:00 2001 From: Eric Blankenhorn Date: Fri, 7 Aug 2026 14:30:49 -0500 Subject: [PATCH 2/2] Fix from review --- lib/wolfssl | 2 +- scripts/build_ffi.py | 4 +--- 2 files changed, 2 insertions(+), 4 deletions(-) diff --git a/lib/wolfssl b/lib/wolfssl index 59f4fa5..ac01707 160000 --- a/lib/wolfssl +++ b/lib/wolfssl @@ -1 +1 @@ -Subproject commit 59f4fa568615396fbf381b073b220d1e8d61e4c2 +Subproject commit ac01707f552c611fbd135cc723b2682b3e7f80f2 diff --git a/scripts/build_ffi.py b/scripts/build_ffi.py index 411fc9f..6807edf 100644 --- a/scripts/build_ffi.py +++ b/scripts/build_ffi.py @@ -235,9 +235,7 @@ def make_flags(prefix, fips): # ML-KEM flags.append("--enable-mlkem") - # ML-DSA (note: to be able to use the legacy option of signing without context, pass `yes,draft` as - # argument -- wolfSSL has no `no-ctx` option; `draft` defines WOLFSSL_DILITHIUM_FIPS204_DRAFT, which - # also switches to the pre-FIPS-204 draft signature format) + # ML-DSA (note: to be able to use the legacy option of signing without context, pass `yes,no-ctx` as argument) flags.append("--enable-mldsa=yes") # disabling other configs enabled by default