give debug log hint about hash min size and adjust configure with CI#228
Open
JacobBarthelmeh wants to merge 1 commit into
Open
give debug log hint about hash min size and adjust configure with CI#228JacobBarthelmeh wants to merge 1 commit into
JacobBarthelmeh wants to merge 1 commit into
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates wolfCLU’s dgst sign/verify path to surface an additional hint when MD5 signatures fail due to wolfSSL’s minimum signature-hash policy, and adjusts GitHub Actions CI to build wolfSSL with that minimum lowered so existing MD5-related test cases keep passing.
Changes:
- Capture and inspect
wc_SignatureVerify/wc_SignatureGeneratereturn codes to optionally print an MD5-specific hint onBAD_FUNC_ARG. - Update CI’s wolfSSL
./configureinvocation to defineWC_SIG_MIN_HASH_TYPE=WC_HASH_TYPE_MD5during the wolfSSL build.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
src/sign-verify/clu_dgst_setup.c |
Adds MD5-specific diagnostic logging based on BAD_FUNC_ARG from signature verify/generate. |
.github/workflows/ci.yml |
Forces wolfSSL CI builds to lower WC_SIG_MIN_HASH_TYPE to MD5 to keep MD5 test cases working. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+419
to
+420
| WOLFCLU_LOG(WOLFCLU_L0, | ||
| "Note: MD5 below default min sig hash on wolfSSL > 5.9.1"); |
Comment on lines
+461
to
+462
| WOLFCLU_LOG(WOLFCLU_L0, | ||
| "Note: MD5 below default min sig hash on wolfSSL > 5.9.1"); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.