From 5ea89a2cb469386c41aad1752adefb59e2feaa8b Mon Sep 17 00:00:00 2001 From: Rob Landry Date: Sat, 30 May 2026 19:12:21 -0700 Subject: [PATCH] fix: drain binding test child stdio --- src/bindings/utils/testBindingBinary.ts | 18 +++++++----------- 1 file changed, 7 insertions(+), 11 deletions(-) diff --git a/src/bindings/utils/testBindingBinary.ts b/src/bindings/utils/testBindingBinary.ts index 4a40b12b..85361acf 100644 --- a/src/bindings/utils/testBindingBinary.ts +++ b/src/bindings/utils/testBindingBinary.ts @@ -129,9 +129,7 @@ export async function testBindingBinary( const subProcess = forkFunction.fork(__filename, [], { detached: false, silent: true, - stdio: pipeOutputOnNode - ? ["ignore", "pipe", "pipe", "ipc"] - : ["ignore", "ignore", "ignore", "ipc"], + stdio: ["ignore", "pipe", "pipe", "ipc"], env: { ...process.env, TEST_BINDING_CP: "true" @@ -161,24 +159,22 @@ export async function testBindingBinary( onExit(subProcess.exitCode ?? -1); } - function onStdout(data: string) { - if (!pipeSet) + function onStdout(data: string | Buffer) { + if (!pipeOutputOnNode || !pipeSet) return; process.stdout.write(data); } - function onStderr(data: string) { - if (!pipeSet) + function onStderr(data: string | Buffer) { + if (!pipeOutputOnNode || !pipeSet) return; process.stderr.write(data); } - if (pipeOutputOnNode) { - subProcess.stdout?.on("data", onStdout); - subProcess.stderr?.on("data", onStderr); - } + subProcess.stdout?.on("data", onStdout); + subProcess.stderr?.on("data", onStderr); function pipeMessages() { if (!pipeOutputOnNode || pipeSet)