-
Notifications
You must be signed in to change notification settings - Fork 34
refactor: rename PM Battle to Spec Clarification #192
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Rename "PM Battle" mode to "Spec Clarification" for better clarity and professionalism: - Frontend i18n: Update zh-CN and en titles from "PM Battle" to "Spec Clarification" - Documentation: Rename guide files and update all references - pm-battle-guide.md → spec-clarification-guide.md (both zh/en) - Update all content mentions of "PM Battle" to "Spec Clarification" - Backend config: Rename YAML resources - pm-battle-ghost → spec-clarification-ghost - pm-battle-bot → spec-clarification-bot - pm-battle-team → spec-clarification-team - Update system prompt description to "Software Requirements Analyst" - Update documentation links in README files (zh/en) This change improves user-facing terminology while maintaining all functionality.
|
Caution Review failedThe pull request is closed. WalkthroughRenames "PM Battle" entities and branding to "Spec Clarification" across backend default resources, documentation (EN/ZH), and frontend i18n files; updates cross-references, systemPrompt wording, and UI labels accordingly. Changes
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes
Possibly related PRs
Suggested reviewers
Poem
Pre-merge checks and finishing touches✅ Passed checks (3 passed)
📜 Recent review detailsConfiguration used: CodeRabbit UI Review profile: CHILL Plan: Pro 📒 Files selected for processing (3)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (1)
docs/zh/guides/user/spec-clarification-guide.md (1)
5-5: Minor grammar suggestion (optional).Line 5 phrase "将模糊需求精炼为清晰的开发任务" is acceptable but may benefit from revision. Per Chinese grammar conventions, consider "将模糊需求精炼为清晰地定义开发任务" for more direct adverbial modification of the verb, or restructure as "将模糊需求精炼为明确的开发任务" (using "明确" instead). Current phrasing is understandable, so this is a nitpick.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (7)
backend/init_data/01-default-resources.yaml(3 hunks)docs/en/README.md(1 hunks)docs/en/guides/user/spec-clarification-guide.md(4 hunks)docs/zh/README.md(1 hunks)docs/zh/guides/user/spec-clarification-guide.md(4 hunks)frontend/src/i18n/locales/en/chat.json(1 hunks)frontend/src/i18n/locales/zh-CN/chat.json(1 hunks)
🧰 Additional context used
📓 Path-based instructions (1)
frontend/**
📄 CodeRabbit inference engine (AGENTS.md)
Frontend: Only use
NEXT_PUBLIC_*for client-safe environment variables
Files:
frontend/src/i18n/locales/zh-CN/chat.jsonfrontend/src/i18n/locales/en/chat.json
🧠 Learnings (1)
📚 Learning: 2025-11-26T07:34:32.573Z
Learnt from: CR
Repo: wecode-ai/Wegent PR: 0
File: AGENTS.md:0-0
Timestamp: 2025-11-26T07:34:32.573Z
Learning: Use Kubernetes-inspired CRD design (Ghost, Model, Shell, Bot, Team, Task)
Applied to files:
backend/init_data/01-default-resources.yaml
🪛 LanguageTool
docs/zh/guides/user/spec-clarification-guide.md
[uncategorized] ~5-~5: 动词的修饰一般为‘形容词(副词)+地+动词’。您的意思是否是:清晰"地"开发
Context: ...egent 系统的交互式需求澄清模式,帮助用户通过结构化问答将模糊需求精炼为清晰的开发任务。 ## 快速开始 ### 1. 系统初始化 系统首次启动时会自动...
(wb4)
🔇 Additional comments (11)
frontend/src/i18n/locales/en/chat.json (1)
114-114: Terminology update looks good.Renaming from "PM Battle - Requirement Clarification" to "Spec Clarification" is clearer and more professional. Change is consistent with the PR objectives.
frontend/src/i18n/locales/zh-CN/chat.json (1)
114-114: Chinese localization properly aligned.The Chinese title update mirrors the English change while maintaining appropriate phrasing for Chinese users. Adding "(Spec Clarification)" in parentheses provides good clarity.
docs/zh/README.md (1)
37-37: Documentation link and label updated correctly.Both the link target and display text reflect the new Spec Clarification terminology. Ensure the corresponding guide file (
guides/user/spec-clarification-guide.md) has been created or renamed accordingly.docs/en/README.md (1)
37-37: English documentation link consistent with Chinese version.Updates maintain parallel structure across language-specific documentation. Verify that
spec-clarification-guide.mdguide files exist in bothdocs/en/guides/user/anddocs/zh/guides/user/directories.docs/zh/guides/user/spec-clarification-guide.md (1)
1-15: Entity references properly updated throughout guide.All entity names consistently updated from
pm-battle-*tospec-clarification-*(Ghost, Bot, Team), aligning with backend resource definitions. Cross-references in system prompts, data flow diagrams (line 64), and customization sections (lines 166-177) are coherent.docs/en/guides/user/spec-clarification-guide.md (2)
1-15: English guide properly mirrors Chinese version naming updates.Title and all entity references (Ghost, Bot, Team) consistently renamed to
spec-clarification-*. Terminology aligns with backend resources and Chinese documentation.
166-177: Customization section entity references updated correctly.System prompt, Ghost, Bot, and Team reference updates in the customization guide section are consistent with the rest of the document and backend resource definitions.
backend/init_data/01-default-resources.yaml (4)
141-147: Ghost resource properly renamed and role updated.Resource name changed from
pm-battle-ghosttospec-clarification-ghostwith corresponding system prompt updated to reflect "Software Requirements Analyst" role. The new prompt includes comprehensive formatting and workflow specifications for requirement clarification tasks.
361-376: Bot resource renamed with correct Ghost reference.Bot metadata.name updated to
spec-clarification-botand ghostRef.name properly updated tospec-clarification-ghost, maintaining referential integrity.
380-392: Team resource renamed with correct Bot reference.Team metadata.name updated to
spec-clarification-teamand member botRef.name properly updated tospec-clarification-bot, maintaining referential integrity across the CRD hierarchy.
1-392: No pm-battle- references remain in the codebase—renaming is complete and consistent.*Verification confirms:
- Zero
pm-battle-*references found across the entire codebase and backend directoryspec-clarification-*resources (ghost, bot, team) are properly defined inbackend/init_data/01-default-resources.yamlwith consistent naming- All resource references in Teams and documentation are aligned with the new naming pattern
- No orphaned or inconsistent resources detected
The transition from
pm-battle-*tospec-clarification-*has been completed successfully throughout the configuration and documentation.
Summary
This PR renames "PM Battle" mode to "Spec Clarification" across the entire project for better clarity and professionalism.
Changes
Frontend
Documentation
pm-battle-guide.md→spec-clarification-guide.md(both zh and en)Backend
backend/init_data/01-default-resources.yaml):pm-battle-ghost→spec-clarification-ghostpm-battle-bot→spec-clarification-botpm-battle-team→spec-clarification-teamImpact
Test Plan
Related Issues
Addresses user feedback requesting more professional terminology for the requirement clarification feature.
Summary by CodeRabbit
Product Updates
Documentation
Localization
✏️ Tip: You can customize this high-level summary in your review settings.