Validate crawls successful and coll exists before updating crawls

Author: tw4l

backend/btrixcloud/basecrawls.py

@@ -614,8 +614,6 @@ async def add_to_collection(
         self, crawl_ids: List[str], collection_id: UUID, org: Organization
     ):
         """Add crawls to collection."""
-        await self.validate_all_crawls_successful(crawl_ids)
-
         await self.crawls.update_many(
             {"_id": {"$in": crawl_ids}, "oid": org.id},
             {"$addToSet": {"collectionIds": collection_id}},

backend/btrixcloud/colls.py

@@ -231,7 +231,7 @@ async def add_crawls_to_collection(
         headers: Optional[dict] = None,
     ) -> CollOut:
         """Add crawls to collection"""
-        await self.crawl_ops.add_to_collection(crawl_ids, coll_id, org)
+        await self.crawl_ops.validate_all_crawls_successful(crawl_ids)
 
         modified = dt_now()
         result = await self.collections.find_one_and_update(
@@ -242,6 +242,8 @@ async def add_crawls_to_collection(
         if not result:
             raise HTTPException(status_code=404, detail="collection_not_found")
 
+        await self.crawl_ops.add_to_collection(crawl_ids, coll_id, org)
+
         await self.update_collection_counts_and_tags(coll_id)
         await self.update_collection_dates(coll_id, org.id)