Skip to content

fix: skip HMR websocket path when forwarding upgrades to user-defined proxies#5677

Closed
bjohansebas wants to merge 2 commits into
nextfrom
ws-fixed
Closed

fix: skip HMR websocket path when forwarding upgrades to user-defined proxies#5677
bjohansebas wants to merge 2 commits into
nextfrom
ws-fixed

Conversation

@bjohansebas
Copy link
Copy Markdown
Member

Summary

What kind of change does this PR introduce?

Did you add tests for your changes?

Does this PR introduce a breaking change?

If relevant, what needs to be documented once your changes are merged or what have you already documented?

Use of AI

@bjohansebas
Copy link
Copy Markdown
Member Author

ref: #4316

@codecov
Copy link
Copy Markdown

codecov Bot commented May 23, 2026

Codecov Report

❌ Patch coverage is 43.47826% with 13 lines in your changes missing coverage. Please review.
✅ Project coverage is 81.52%. Comparing base (28ecc85) to head (3cad324).

Files with missing lines Patch % Lines
lib/Server.js 43.47% 13 Missing ⚠️

❗ There is a different number of reports uploaded between BASE (28ecc85) and HEAD (3cad324). Click for more details.

HEAD has 38 uploads less than BASE
Flag BASE (28ecc85) HEAD (3cad324)
41 3
Additional details and impacted files
@@            Coverage Diff             @@
##             next    #5677      +/-   ##
==========================================
- Coverage   88.85%   81.52%   -7.33%     
==========================================
  Files          13       11       -2     
  Lines        5893     4904     -989     
==========================================
- Hits         5236     3998    -1238     
- Misses        657      906     +249     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@bjohansebas bjohansebas deleted the ws-fixed branch May 23, 2026 22:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant