Skip to content

fix: skip HMR websocket path when forwarding upgrades to user-defined proxies#4316

Open
ajhyndman wants to merge 3 commits into
webpack:mainfrom
ajhyndman:patch-1
Open

fix: skip HMR websocket path when forwarding upgrades to user-defined proxies#4316
ajhyndman wants to merge 3 commits into
webpack:mainfrom
ajhyndman:patch-1

Conversation

@ajhyndman
Copy link
Copy Markdown

  • This is a bugfix
  • This is a feature
  • This is a code refactor
  • This is a test update
  • This is a docs update
  • This is a metadata update

For Bugs and Features; did you add new tests?

Please let me know what kind of test could be appropriate for this change.

Motivation / Use-Case

Both create-react-app and vue-cli-service have introduced workarounds for this, but it seems to me that this is always desirable behaviour for webpack-dev-server.

vuejs/vue-cli@72ba750
react/create-react-app#7444

@linux-foundation-easycla
Copy link
Copy Markdown

linux-foundation-easycla Bot commented Feb 27, 2022

CLA Signed

The committers are authorized under a signed CLA.

Copy link
Copy Markdown
Member

@alexander-akait alexander-akait left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add test case and fix types?

ajhyndman and others added 2 commits May 23, 2026 17:11
Both create-react-app and vue-cli-service have introduced workarounds for this, but it seems to me that this is always desirable behaviour for webpack-dev-server.

vuejs/vue-cli@72ba750
react/create-react-app#7444
@codecov
Copy link
Copy Markdown

codecov Bot commented May 23, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 83.60%. Comparing base (b550a70) to head (686903d).
⚠️ Report is 4 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4316      +/-   ##
==========================================
+ Coverage   83.59%   83.60%   +0.01%     
==========================================
  Files          13       13              
  Lines        2054     2086      +32     
  Branches      756      773      +17     
==========================================
+ Hits         1717     1744      +27     
- Misses        303      306       +3     
- Partials       34       36       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@bjohansebas bjohansebas changed the title fix: never proxy hot-reload websocket requests fix: skip HMR websocket path when forwarding upgrades to user-defined proxies May 23, 2026
@bjohansebas bjohansebas requested review from UlisesGascon and alexander-akait and removed request for anshumanv, hiroppy, knagaitsev and snitin315 May 23, 2026 22:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants