Static analysis suite rendered useless by past refactoring?

[Ocramius]

See b5addd4

In this commit, the static analysis test suite was rendered non-functional.

For instance:

/**
 * @psalm-pure
 *
 * @param mixed $value
- *
- * @return iterable<string>
 */
function allString($value): iterable
{
    Assert::allString($value);

    return $value;
}

This rendered the main purpose of the allString() function moot: static analysis tooling is no longer picking up if an iterable<string> is being produced

[shadowhand]

The allString() function is a test-only function. Is psalm really so brittle that it doesn't understand that Assert::allString($value) has implicitly made iterable<string> $value?

[Ocramius]

allString() was there to verify that the interaction between this library and Psalm worked: here it as if we removed the assertion from a test 😅

[zerkms]

Is psalm really so brittle

Without @return iterable<string> annotation now the return type is iterable. So a party that calls this allString function only can assume that the mixed $value is now an iterable<mixed>.

In this very case @return iterable<string> fills the gap of the php's type system's lack of generics and inability to declare iterable<string> as a native return type.

[shadowhand]

So this is different than how PHPStan works? When we do:

Assert::allAlnum($value);

Then PHPStan understands that $value has type iterable<string> for any following code.

[zerkms]

That's surprising: the function's signature is function allString($value): iterable, which returns iterable<mixed>.

I don't tell that phpstan's behaviour is right or wrong, but nothing in signature points to iterable<string> anymore.