Skip to content

Conversation

@vm-001
Copy link
Collaborator

@vm-001 vm-001 commented Nov 6, 2025

Summary

This PR added inbound plugins basic-auth, key-auth, and hmac-auth.

To support more types in the feature (currently only HTTP), this PR includes a refactor of the Source object, that move fields path, methods, and response into config.http.

#226

@vm-001 vm-001 marked this pull request as draft November 6, 2025 10:10
@vm-001 vm-001 marked this pull request as ready for review November 6, 2025 10:11
@vm-001 vm-001 force-pushed the feat/source-auth branch 2 times, most recently from 96fbba5 to e8be209 Compare November 6, 2025 10:20
@codecov
Copy link

codecov bot commented Nov 6, 2025

Codecov Report

❌ Patch coverage is 89.24731% with 10 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
plugins/hmac-auth/plugin.go 81.81% 5 Missing and 1 partial ⚠️
plugins/basic-auth/plugin.go 81.81% 2 Missing ⚠️
plugins/key-auth/plugin.go 92.00% 2 Missing ⚠️
Flag Coverage Δ
integration 73.57% <86.02%> (+0.15%) ⬆️
integration-o11 43.02% <7.52%> (-0.68%) ⬇️
unit 12.94% <2.15%> (-0.17%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
admin/api/sources.go 87.50% <100.00%> (+0.83%) ⬆️
db/entities/source.go 60.00% <100.00%> (-40.00%) ⬇️
plugins/plugins.go 100.00% <100.00%> (ø)
proxy/gateway.go 77.39% <100.00%> (ø)
utils/validate.go 66.23% <100.00%> (+0.44%) ⬆️
plugins/basic-auth/plugin.go 81.81% <81.81%> (ø)
plugins/key-auth/plugin.go 92.00% <92.00%> (ø)
plugins/hmac-auth/plugin.go 81.81% <81.81%> (ø)

... and 3 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@vm-001 vm-001 force-pushed the feat/source-auth branch 11 times, most recently from ff56b7b to d65dc70 Compare November 7, 2025 09:06
@vm-001 vm-001 force-pushed the refactor/configuration branch 5 times, most recently from e6d1d23 to ef9e875 Compare November 10, 2025 18:15
Base automatically changed from refactor/configuration to main November 10, 2025 18:29
@vm-001 vm-001 force-pushed the feat/source-auth branch 5 times, most recently from 16e0e3b to ef71522 Compare November 17, 2025 07:01
@webhookx-x webhookx-x merged commit 7c2f1dc into main Nov 17, 2025
9 checks passed
@webhookx-x webhookx-x deleted the feat/source-auth branch November 17, 2025 10:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants