fix: avoid caching unexpected response result (#7854)

Author: yimingjfe

.changeset/busy-animals-stand.md

@@ -0,0 +1,6 @@
+---
+'@modern-js/server-core': patch
+---
+
+fix: Avoid caching unexpected responses
+fix: 避免不受期待的响应被缓存

packages/server/core/src/plugins/render/ssrCache.ts

@@ -44,6 +44,12 @@ async function processCache({
   const response = await requestHandler(request, requestHandlerOptions);
   const { onError } = requestHandlerOptions;
 
+  // Do not cache responses with certain status codes
+  const nonCacheableStatusCodes = [204, 305, 404, 405, 500, 501, 502, 503, 504];
+  if (nonCacheableStatusCodes.includes(response.status)) {
+    return response;
+  }
+
   const decoder: TextDecoder = new TextDecoder();
 
   if (response.body) {
@@ -136,6 +142,19 @@ function computedKey(req: Request, cacheControl: CacheControl): string {
 
 type MaybeAsync<T> = Promise<T> | T;
 
+/**
+ * Check if a request should be processed through cache logic
+ */
+export function shouldUseCache(request: Request): boolean {
+  const url = new URL(request.url);
+  const hasRSCAction = request.headers.has('x-rsc-action');
+  const hasRSCTree = request.headers.has('x-rsc-tree');
+  const hasLoaderQuery = url.searchParams.has('__loader');
+
+  // Skip cache for RSC requests or loader requests
+  return !(hasRSCAction || hasRSCTree || hasLoaderQuery);
+}
+
 export function matchCacheControl(
   cacheOption?: CacheOption,
   // TODO: remove nodeReq

packages/server/core/src/plugins/render/ssrRender.ts

@@ -18,7 +18,7 @@ import type {
   RequestHandlerOptions,
 } from '../../types/requestHandler';
 import { getPathname, parseHeaders } from '../../utils';
-import { getCacheResult, matchCacheControl } from './ssrCache';
+import { getCacheResult, matchCacheControl, shouldUseCache } from './ssrCache';
 import { createRequestHandlerConfig } from './utils';
 
 // TODO: It's a type combine by RenderOptions and CreateRenderOptions, improve it.
@@ -135,7 +135,7 @@ export async function ssrRender(
 
   let response: Response;
 
-  if (cacheControl) {
+  if (cacheControl && shouldUseCache(request)) {
     response = await getCacheResult(request, {
       cacheControl,
       container: cacheConfig?.container,