Skip to content

Commit a75df02

Browse files
updated generic tests to use the default mockserver
1 parent c5c4d7c commit a75df02

File tree

1 file changed

+10
-46
lines changed

1 file changed

+10
-46
lines changed

src/test/java/com/ibm/watson/developer_cloud/service/GenericServiceTest.java

Lines changed: 10 additions & 46 deletions
Original file line numberDiff line numberDiff line change
@@ -13,48 +13,27 @@
1313
*/
1414
package com.ibm.watson.developer_cloud.service;
1515

16-
import static org.mockserver.integration.ClientAndServer.startClientAndServer;
1716
import static org.mockserver.model.HttpRequest.request;
1817
import static org.mockserver.model.HttpResponse.response;
1918

2019
import java.util.HashMap;
2120
import java.util.Map;
22-
import java.util.logging.Level;
23-
import java.util.logging.Logger;
2421

25-
import org.junit.After;
2622
import org.junit.Before;
2723
import org.junit.Test;
28-
import org.mockserver.integration.ClientAndServer;
2924
import org.mockserver.model.Header;
3025
import org.mockserver.model.HttpRequest;
3126

32-
import com.ibm.watson.developer_cloud.WatsonServiceTest;
27+
import com.ibm.watson.developer_cloud.WatsonServiceUnitTest;
3328
import com.ibm.watson.developer_cloud.http.HttpHeaders;
3429
import com.ibm.watson.developer_cloud.personality_insights.v2.PersonalityInsights;
35-
import com.ibm.watson.developer_cloud.personality_insights.v2.PersonalityInsightsTest;
3630

3731
/**
38-
* The Class GenericServiceTest.
32+
* Generic Service Test.
3933
*/
40-
public class GenericServiceTest extends WatsonServiceTest {
41-
42-
/** The Constant GET_PROFILE_PATH. */
34+
public class GenericServiceTest extends WatsonServiceUnitTest {
4335
private final static String GET_PROFILE_PATH = "/v2/profile";
44-
45-
/** The Constant log. */
46-
private static final Logger log = Logger.getLogger(PersonalityInsightsTest.class.getName());
47-
48-
/** The Constant POST. */
49-
private static final String POST = "POST";
50-
51-
/** Mock Server *. */
52-
private ClientAndServer mockServer;
53-
54-
/** The sample text. */
5536
private final String sampleText = "this is a test";
56-
57-
/** The service. */
5837
private PersonalityInsights service;
5938

6039
/**
@@ -86,28 +65,13 @@ public void ServiceUnavailableException() {
8665
service.getProfile(sampleText);
8766
}
8867

89-
/**
90-
* Start mock server.
91-
*/
68+
@Override
9269
@Before
93-
public void startMockServer() {
94-
try {
95-
mockServer = startClientAndServer(Integer.parseInt(getValidProperty("mock.server.port")));
96-
service = new PersonalityInsights();
97-
service.setApiKey("");
98-
service.setEndPoint("http://" + getValidProperty("mock.server.host") + ":"
99-
+ getValidProperty("mock.server.port"));
100-
} catch (final NumberFormatException e) {
101-
log.log(Level.SEVERE, "Error mocking the service", e);
102-
}
103-
}
104-
105-
/**
106-
* Stop mock server.
107-
*/
108-
@After
109-
public void stopMockServer() {
110-
mockServer.stop();
70+
public void setUp() throws Exception {
71+
super.setUp();
72+
service = new PersonalityInsights();
73+
service.setApiKey("");
74+
service.setEndPoint(MOCK_SERVER_URL);
11175
}
11276

11377
/**
@@ -221,7 +185,7 @@ public void testDefaultHeadersAreSet() {
221185
service.setDefaultHeaders(headers);
222186
mockAPICall();
223187
service.getProfile(sampleText);
224-
mockServer.verify(new HttpRequest().withMethod("POST").withHeader(expectedHeader1)
188+
mockServer.verify(new HttpRequest().withMethod(POST).withHeader(expectedHeader1)
225189
.withHeader(expectedHeader2));
226190
}
227191
}

0 commit comments

Comments
 (0)