Skip to content

Commit 4871c0e

Browse files
Merge pull request #244 from GrapeBaBa/master
[Language-translation] fix issue #240
2 parents e1ab4b8 + a9b10f2 commit 4871c0e

File tree

4 files changed

+56
-10
lines changed

4 files changed

+56
-10
lines changed

src/main/java/com/ibm/watson/developer_cloud/language_translation/v2/LanguageTranslation.java

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,8 @@
2424
import com.ibm.watson.developer_cloud.language_translation.v2.model.CreateModelOptions;
2525
import com.ibm.watson.developer_cloud.language_translation.v2.model.IdentifiableLanguage;
2626
import com.ibm.watson.developer_cloud.language_translation.v2.model.IdentifiedLanguage;
27-
import com.ibm.watson.developer_cloud.language_translation.v2.model.LanguageList;
27+
import com.ibm.watson.developer_cloud.language_translation.v2.model.IdentifiableLanguageList;
28+
import com.ibm.watson.developer_cloud.language_translation.v2.model.IdentifiedLanguageList;
2829
import com.ibm.watson.developer_cloud.language_translation.v2.model.TranslationModel;
2930
import com.ibm.watson.developer_cloud.language_translation.v2.model.TranslationModelList;
3031
import com.ibm.watson.developer_cloud.language_translation.v2.model.TranslationResult;
@@ -144,7 +145,7 @@ public void deleteModel(String modelId) {
144145
*/
145146
public List<IdentifiableLanguage> getIdentifiableLanguages() {
146147
final RequestBuilder requestBuilder = RequestBuilder.get(PATH_IDENTIFIABLE_LANGUAGES);
147-
final LanguageList languages = executeRequest(requestBuilder.build(), LanguageList.class);
148+
final IdentifiableLanguageList languages = executeRequest(requestBuilder.build(), IdentifiableLanguageList.class);
148149
return languages.getLanguages();
149150
}
150151

@@ -206,15 +207,14 @@ public List<TranslationModel> getModels(final Boolean showDefault, final String
206207
* @param text the text to identify
207208
* @return the identified language
208209
*/
209-
@SuppressWarnings("unchecked")
210210
public List<IdentifiedLanguage> identify(final String text) {
211211
final Request request = RequestBuilder.post(PATH_IDENTIFY)
212212
.withHeader(HttpHeaders.ACCEPT, HttpMediaType.APPLICATION_JSON)
213213
.withBodyContent(text, HttpMediaType.TEXT_PLAIN).build();
214214

215-
final LanguageList languages = executeRequest(request, LanguageList.class);
215+
final IdentifiedLanguageList languages = executeRequest(request, IdentifiedLanguageList.class);
216216

217-
return (List<IdentifiedLanguage>) (List<?>) languages.getLanguages();
217+
return languages.getLanguages();
218218
}
219219

220220
/**

src/main/java/com/ibm/watson/developer_cloud/language_translation/v2/model/LanguageList.java renamed to src/main/java/com/ibm/watson/developer_cloud/language_translation/v2/model/IdentifiableLanguageList.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -19,10 +19,10 @@
1919
import com.ibm.watson.developer_cloud.service.model.GenericModel;
2020

2121
/**
22-
* Language list used by the {@link LanguageTranslation} service.
22+
* Identifiable language list used by the {@link LanguageTranslation} service.
2323
*
2424
*/
25-
public class LanguageList extends GenericModel {
25+
public class IdentifiableLanguageList extends GenericModel {
2626

2727
private List<IdentifiableLanguage> languages;
2828

Lines changed: 46 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,46 @@
1+
/**
2+
* Copyright 2015 IBM Corp. All Rights Reserved.
3+
*
4+
* Licensed under the Apache License, Version 2.0 (the "License"); you may not use this file except
5+
* in compliance with the License. You may obtain a copy of the License at
6+
*
7+
* http://www.apache.org/licenses/LICENSE-2.0
8+
*
9+
* Unless required by applicable law or agreed to in writing, software distributed under the License
10+
* is distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express
11+
* or implied. See the License for the specific language governing permissions and limitations under
12+
* the License.
13+
*/
14+
package com.ibm.watson.developer_cloud.language_translation.v2.model;
15+
16+
import java.util.List;
17+
18+
import com.ibm.watson.developer_cloud.language_translation.v2.LanguageTranslation;
19+
import com.ibm.watson.developer_cloud.service.model.GenericModel;
20+
21+
/**
22+
* Identified language list used by the {@link LanguageTranslation} service.
23+
*
24+
*/
25+
public class IdentifiedLanguageList extends GenericModel {
26+
27+
private List<IdentifiedLanguage> languages;
28+
29+
/**
30+
* Gets the languages.
31+
*
32+
* @return the languages
33+
*/
34+
public List<IdentifiedLanguage> getLanguages() {
35+
return languages;
36+
}
37+
38+
/**
39+
* Sets the languages.
40+
*
41+
* @param languages the new languages
42+
*/
43+
public void setLanguages(List<IdentifiedLanguage> languages) {
44+
this.languages = languages;
45+
}
46+
}

src/test/java/com/ibm/watson/developer_cloud/language_translation/v2/LanguageTranslationTest.java

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -39,7 +39,7 @@
3939
import com.ibm.watson.developer_cloud.language_translation.v2.model.CreateModelOptions;
4040
import com.ibm.watson.developer_cloud.language_translation.v2.model.IdentifiableLanguage;
4141
import com.ibm.watson.developer_cloud.language_translation.v2.model.IdentifiedLanguage;
42-
import com.ibm.watson.developer_cloud.language_translation.v2.model.LanguageList;
42+
import com.ibm.watson.developer_cloud.language_translation.v2.model.IdentifiableLanguageList;
4343
import com.ibm.watson.developer_cloud.language_translation.v2.model.Translation;
4444
import com.ibm.watson.developer_cloud.language_translation.v2.model.TranslationModel;
4545
import com.ibm.watson.developer_cloud.language_translation.v2.model.TranslationModelList;
@@ -57,7 +57,7 @@ public class LanguageTranslationTest extends WatsonServiceUnitTest {
5757
private String modelId;
5858
private LanguageTranslation service;
5959
private String text;
60-
private LanguageList identifiableLanguages;
60+
private IdentifiableLanguageList identifiableLanguages;
6161
private TranslationModel model;
6262
private TranslationModelList models;
6363

@@ -79,7 +79,7 @@ public void setUp() throws Exception {
7979

8080
// fixtures
8181
identifiableLanguages =
82-
loadFixture(RESOURCE + "identifiable_languages.json", LanguageList.class);
82+
loadFixture(RESOURCE + "identifiable_languages.json", IdentifiableLanguageList.class);
8383
model = loadFixture(RESOURCE + "model.json", TranslationModel.class);
8484
models = loadFixture(RESOURCE + "models.json", TranslationModelList.class);
8585
}

0 commit comments

Comments
 (0)