refactor(compiler): move operation with constant values out of renderEffect

Copy from https://github.com/vuejs/core/pull/12547/files

Author: zhiyuanzmj

packages/compiler/src/transform.ts

@@ -1,6 +1,7 @@
 import {
   defaultOnError,
   defaultOnWarn,
+  isConstantNode,
   type TransformOptions as BaseTransformOptions,
   type CommentNode,
   type CompilerCompatOptions,
@@ -163,9 +164,15 @@ export class TransformContext<
     ...operations: OperationNode[]
   ) {
     expressions = expressions.filter((exp) => !isConstantExpression(exp))
-    if (this.inVOnce || expressions.length === 0) {
+    if (
+      this.inVOnce ||
+      expressions.length === 0 ||
+      expressions.every((e) => e.ast && isConstantNode(e.ast, {}))
+    ) {
       return this.registerOperation(...operations)
     }
+
+    this.block.expressions.push(...expressions)
     const existing = this.block.effect.find((e) =>
       isSameExpression(e.expressions, expressions),
     )

packages/compiler/test/transforms/__snapshots__/vBind.spec.ts.snap

@@ -0,0 +1,23 @@
+// Vitest Snapshot v1, https://vitest.dev/guide/snapshot.html
+
+exports[`compiler v-bind > with constant value 1`] = `
+"
+  const n0 = t0()
+  _setProp(n0, "a", void 0)
+  _setProp(n0, "b", 1 > 2)
+  _setProp(n0, "c", 1 + 2)
+  _setProp(n0, "d", 1 ? 2 : 3)
+  _setProp(n0, "e", 2)
+  _setProp(n0, "f", \`foo1\`)
+  _setProp(n0, "g", 1)
+  _setProp(n0, "i", true)
+  _setProp(n0, "j", null)
+  _setProp(n0, "l", { foo: 1 })
+  _setProp(n0, "n", { ...{ foo: 1 } })
+  _setProp(n0, "o", [1, , 3])
+  _setProp(n0, "p", [1, ...[2, 3]])
+  _setProp(n0, "q", [1, 2])
+  _setProp(n0, "r", /\\s+/)
+  return n0
+"
+`;

packages/compiler/test/transforms/vBind.spec.ts

@@ -532,4 +532,29 @@ describe('compiler v-bind', () => {
     expect(code).contains('_setAttr(n0, "foo-bar", _ctx.fooBar)')
   })
     */
+
+  test('with constant value', () => {
+    const { code } = compileWithVBind(
+      `
+        <div
+          a={void 0}
+          b={1 > 2} 
+          c={1 + 2}
+          d={1 ? 2 : 3}
+          e={(2)}
+          f={\`foo${1}\`}
+          g={1}
+          h={'1'}
+          i={true}
+          j={null}
+          l={{ foo: 1 }}
+          n={{ ...{ foo: 1 } }}
+          o={[1, , 3]}
+          p={[1, ...[2, 3]]}
+          q={[1, 2]}
+          r={/\\s+/}
+        />`,
+    )
+    expect(code).matchSnapshot()
+  })
 })