workflow: enable eslint node/no-extraneous-require

Author: yyx990803

.eslintignore

@@ -3,3 +3,4 @@ template
 packages/test
 temp
 entry-wc.js
+dist

.eslintrc

@@ -0,0 +1,29 @@
+module.exports = {
+  extends: [
+    "plugin:vue-libs/recommended"
+  ],
+  plugins: [
+    "node"
+  ],
+  env: {
+    "jest": true
+  },
+  rules: {
+    "indent": ["error", 2, {
+      "MemberExpression": "off"
+    }],
+    "node/no-extraneous-require": ["error", {
+      "allowModules": [
+        "@vue/cli-test-utils"
+      ]
+    }]
+  },
+  overrides: [
+    {
+      files: ['**/__tests__/**/*.js', "**/cli-test-utils/**/*.js"],
+      rules: {
+        "node/no-extraneous-require": "off"
+      }
+    }
+  ]
+}

.eslintrc.js

@@ -45,6 +45,7 @@
     "babel-core": "7.0.0-bridge.0",
     "debug": "^3.1.0",
     "eslint": "^4.16.0",
+    "eslint-plugin-node": "^6.0.1",
     "eslint-plugin-vue-libs": "^2.1.0",
     "globby": "^8.0.1",
     "http-server": "^0.11.1",

package.json

@@ -1,15 +1,8 @@
-const chalk = require('chalk')
+module.exports = (api, options) => {
+  const { info, chalk, execa } = require('@vue/cli-shared-utils')
 
-function removeArg (rawArgs, arg) {
-  const matchRE = new RegExp(`^--${arg}`)
-  const equalRE = new RegExp(`^--${arg}=`)
-  const i = rawArgs.findIndex(arg => matchRE.test(arg))
-  if (i > -1) {
-    rawArgs.splice(i, equalRE.test(rawArgs[i]) ? 1 : 2)
-  }
-}
+  console.log(require('@vue/cli-shared-utils'))
 
-module.exports = (api, options) => {
   api.registerCommand('test:e2e', {
     description: 'run e2e tests with Cypress',
     usage: 'vue-cli-service test:e2e [options]',
@@ -27,7 +20,6 @@ module.exports = (api, options) => {
     removeArg(rawArgs, 'mode')
     removeArg(rawArgs, 'url')
 
-    const { info } = require('@vue/cli-shared-utils')
     info(`Starting e2e tests...`)
 
     const { url, server } = args.url
@@ -40,7 +32,6 @@ module.exports = (api, options) => {
       ...rawArgs
     ]
 
-    const execa = require('execa')
     const cypressBinPath = require.resolve('cypress/bin/cypress')
     const runner = execa(cypressBinPath, cyArgs, { stdio: 'inherit' })
     if (server) {
@@ -68,3 +59,12 @@ module.exports = (api, options) => {
 module.exports.defaultModes = {
   'test:e2e': 'production'
 }
+
+function removeArg (rawArgs, arg) {
+  const matchRE = new RegExp(`^--${arg}`)
+  const equalRE = new RegExp(`^--${arg}=`)
+  const i = rawArgs.findIndex(arg => matchRE.test(arg))
+  if (i > -1) {
+    rawArgs.splice(i, equalRE.test(rawArgs[i]) ? 1 : 2)
+  }
+}

packages/@vue/cli-plugin-e2e-cypress/index.js

@@ -22,6 +22,7 @@
     "access": "public"
   },
   "dependencies": {
+    "@vue/cli-shared-utils": "^3.0.0-beta.14",
     "cypress": "^2.1.0",
     "eslint-plugin-cypress": "^2.0.1"
   }

packages/@vue/cli-plugin-e2e-cypress/package.json

@@ -22,6 +22,7 @@
     "access": "public"
   },
   "dependencies": {
+    "@vue/cli-shared-utils": "^3.0.0-beta.14",
     "chromedriver": "^2.38.3",
     "deepmerge": "^2.1.0",
     "execa": "^0.10.0",

packages/@vue/cli-plugin-e2e-nightwatch/package.json

@@ -17,10 +17,9 @@ const renamedArgs = {
 
 module.exports = function lint (args = {}, api) {
   const path = require('path')
-  const chalk = require('chalk')
   const cwd = api.resolve('.')
   const { CLIEngine } = require('eslint')
-  const { log, done, exit } = require('@vue/cli-shared-utils')
+  const { log, done, exit, chalk } = require('@vue/cli-shared-utils')
 
   const files = args._ && args._.length ? args._ : ['src', 'tests', '*.js']
   const extensions = require('./eslintOptions').extensions(api)

packages/@vue/cli-plugin-eslint/lint.js

@@ -22,6 +22,7 @@
     "access": "public"
   },
   "dependencies": {
+    "@vue/cli-shared-utils": "^3.0.0-beta.14",
     "babel-eslint": "^8.2.3",
     "eslint": "^4.19.1",
     "eslint-loader": "^2.0.0",

packages/@vue/cli-plugin-eslint/package.json

@@ -1,8 +1,7 @@
 // these prompts are used if the plugin is late-installed into an existing
 // project and invoked by `vue invoke`.
 
-const chalk = require('chalk')
-const { hasGit } = require('@vue/cli-shared-utils')
+const { chalk, hasGit } = require('@vue/cli-shared-utils')
 
 module.exports = [
   {