Skip to content

Commit 110ab57

Browse files
authored
Remove lockfile (ilyakatz#351)
* Remove lockfile https://yehudakatz.com/2010/12/16/clarifying-the-roles-of-the-gemspec-and-gemfile/ The intent here is to avoid the multiple dev dependencies from raising security issues for consumers of the gem * Extend work by limiting files required for bundling gem * Add missing changelog entries
1 parent b4ee8dd commit 110ab57

File tree

5 files changed

+15
-200
lines changed

5 files changed

+15
-200
lines changed

.gitignore

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -10,3 +10,4 @@ spec/db/data_schema.rb
1010
.ruby-version
1111
.idea/
1212
vendor/
13+
Gemfile.lock

.ruby-style.yml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
AllCops:
2-
TargetRubyVersion: 2.4
2+
TargetRubyVersion: 3.1
33
Include:
44
- "**/*.podspec"
55
- "**/*.jbuilder"
@@ -1058,4 +1058,4 @@ Style/FrozenStringLiteralComment:
10581058
Layout/SpaceBeforeFirstArg:
10591059
Enabled: false
10601060
Style/FormatStringToken:
1061-
Enabled: false
1061+
Enabled: false

Changelog.md

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,12 @@
11
# Changelog
22

3+
# Unreleased
4+
5+
- Remove committed Gemfile.lock, reduce bundled file list when running `gem install` https://github.com/ilyakatz/data-migrate/pull/351
6+
- [Bump actionpack from 7.1.3.4 to 7.1.4.1](https://github.com/ilyakatz/data-migrate/pull/348)
7+
- [Bump rexml from 3.3.6 to 3.3.9](https://github.com/ilyakatz/data-migrate/pull/349)
8+
- Fix db_config_with_versions arity change and backport https://github.com/ilyakatz/data-migrate/pull/337
9+
310
# 11.1.0
411
- Allow multiple data migration paths https://github.com/ilyakatz/data-migrate/pull/331
512
- Fix db:prepare:with_data task on [Rails 7.2](https://github.com/ilyakatz/data-migrate/pull/339)

Gemfile.lock

Lines changed: 0 additions & 192 deletions
This file was deleted.

data_migrate.gemspec

Lines changed: 5 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -15,6 +15,11 @@ Gem::Specification.new do |s|
1515

1616
s.rubyforge_project = "data_migrate"
1717

18+
s.files = Dir["{lib,tasks}/**/*", "Changelog.md", "LICENSE", "README.md"]
19+
s.test_files = `git ls-files -- {test,spec,features}/*`.split("\n")
20+
s.executables = `git ls-files -- bin/*`.split("\n").map{ |f| File.basename(f) }
21+
s.require_paths = ["lib"]
22+
1823
%w[
1924
activerecord
2025
railties
@@ -32,10 +37,4 @@ Gem::Specification.new do |s|
3237
s.add_development_dependency "timecop"
3338
s.add_development_dependency "rubocop"
3439
s.add_development_dependency "overcommit"
35-
36-
37-
s.files = `git ls-files`.split("\n")
38-
s.test_files = `git ls-files -- {test,spec,features}/*`.split("\n")
39-
s.executables = `git ls-files -- bin/*`.split("\n").map{ |f| File.basename(f) }
40-
s.require_paths = ["lib"]
4140
end

0 commit comments

Comments
 (0)