Skip to content
This repository was archived by the owner on Mar 29, 2025. It is now read-only.

Commit a569c35

Browse files
BokoblinArthur Jolivet
andauthored
CCSA-43 UI and translations (#72)
* CCSA-43 ui: Update French translation * CCSA-43 ui: Add my avatar Co-authored-by: Arthur Jolivet <arthur.jolivet@dolby.com>
1 parent ade6371 commit a569c35

File tree

2 files changed

+43
-25
lines changed

2 files changed

+43
-25
lines changed

frontend/src/app/App.js

Lines changed: 37 additions & 21 deletions
Original file line numberDiff line numberDiff line change
@@ -14,25 +14,41 @@ let strings = new LocalizedStrings({
1414
join: "Join call",
1515
name: "Your Name",
1616
admin: "Admin",
17-
conferencename: "Your conference name",
18-
joinDemo: "or experience Voxeet demo",
19-
electronmessage: "Voxeet is loading, please wait",
17+
conferenceName: "Your conference name",
18+
joinDemo: "or experience Dolby.io demo",
19+
electronMessage: "Dolby.io is loading, please wait",
2020
conferenceJoined: "You're in the conference",
2121
copyright: " All Rights Reserved",
2222
next: "Next",
2323
welcome: "Welcome",
24+
joinAsListener: "Join as a listener",
25+
widgetMode: "Widget mode",
26+
simulcast: "Simulcast",
27+
dolbyVoice: "Dolby Voice",
28+
defaultSettings: "Connect using default settings",
29+
advancedOptions: "advanced options",
30+
show: "Show",
31+
hide: "Hide"
2432
},
2533
fr: {
2634
join: "Rejoindre la conférence",
27-
name: "Nom",
35+
name: "Nom d'utilisateur",
2836
admin: "Administrateur",
29-
joinDemo: "ou tester Voxeet demo",
30-
conferencename: "Nom de la conférence",
31-
electronmessage: "Le client Voxeet va démarrer, veuillez patienter",
37+
joinDemo: "ou tester Dolby.io demo",
38+
conferenceName: "Nom de la conférence",
39+
electronMessage: "Le client Dolby.io va démarrer, veuillez patienter",
3240
conferenceJoined: "Vous êtes dans la conférence",
33-
copyright: "Tous Droits Réservés",
34-
next: "Next",
35-
welcome: "Welcome",
41+
copyright: " Tous droits réservés",
42+
next: "Suivant",
43+
welcome: "Bienvenue",
44+
joinAsListener: "Rejoindre en tant qu'auditeur",
45+
widgetMode: "Mode Widget",
46+
simulcast: "Simulcast",
47+
dolbyVoice: "Dolby Voice",
48+
defaultSettings: "Se connecter avec les paramètres par défaut",
49+
advancedOptions: "les options avancées",
50+
show: "Afficher",
51+
hide: "Masquer"
3652
},
3753
});
3854

@@ -216,13 +232,13 @@ class App extends Component {
216232
<h1>{strings.welcome}</h1>
217233
</div>
218234
<div className="dolby-container-logo">
219-
<img src={dolbyLogo} />
235+
<img src={dolbyLogo} alt="Dolby logo" />
220236
</div>
221237
{!this.state.isJoiningFromUrl && (
222238
<div className="input-field">
223239
<input
224240
name="conferenceName"
225-
placeholder={strings.conferencename}
241+
placeholder={strings.conferenceName}
226242
value={this.state.conferenceName}
227243
onChange={this.handleChangeConferenceName}
228244
id="conferenceName"
@@ -246,7 +262,7 @@ class App extends Component {
246262
className="advanced-options"
247263
onClick={() => this.setState({ showOptions: !showOptions })}
248264
>
249-
{`${showOptions ? 'Hide' : 'Show'} advanced options`}
265+
{`${showOptions ? strings.hide : strings.show} ${strings.advancedOptions}`}
250266
<div className={showOptions ? 'arrow-up' : 'arrow-down'} />
251267
</div>
252268
{this.state.showOptions && <React.Fragment>
@@ -257,7 +273,7 @@ class App extends Component {
257273
onChange={this.toggleChangeListener}
258274
/>
259275
<label id="isListenerLabel" htmlFor="isListener">
260-
Join as a listener
276+
{strings.joinAsListener}
261277
</label>
262278

263279
<input
@@ -267,7 +283,7 @@ class App extends Component {
267283
onChange={this.toggleWidgetMode}
268284
/>
269285
<label id="widgetModeLabel" htmlFor="widgetMode">
270-
Widget Mode
286+
{strings.widgetMode}
271287
</label>
272288

273289
<input
@@ -277,7 +293,7 @@ class App extends Component {
277293
onChange={this.toggleSimulcastMode}
278294
/>
279295
<label id="simulcastModeLabel" htmlFor="simulcast">
280-
Simulcast
296+
{strings.simulcast}
281297
</label>
282298

283299
<input
@@ -287,7 +303,7 @@ class App extends Component {
287303
onChange={this.toggleDolbyVoice}
288304
/>
289305
<label id="dolbyVoiceLabel" htmlFor="dolbyvoice">
290-
Dolby Voice
306+
{strings.dolbyVoice}
291307
</label>
292308

293309
<input
@@ -297,17 +313,17 @@ class App extends Component {
297313
onChange={this.toggleConfiguration}
298314
/>
299315
<label id="configurationLabel" htmlFor="configuration">
300-
Connect using default settings
316+
{strings.defaultSettings}
301317
</label>
302318
</React.Fragment>}
303319

304320
<div className="blockButton">
305321
<button
306322
id="join"
307323
type="button"
308-
disabled={this.state.conferenceName.length == 0 ? true : false}
324+
disabled={this.state.conferenceName.length === 0}
309325
className={
310-
this.state.conferenceName.length == 0
326+
this.state.conferenceName.length === 0
311327
? "waves-effect waves-light disable"
312328
: "waves-effect waves-light"
313329
}
@@ -321,7 +337,7 @@ class App extends Component {
321337
</div>
322338
</div>
323339
<div className="copyright">
324-
<span>Copyright © 2021 Dolby — {strings.copyright}</span>
340+
<span>Copyright © {new Date().getFullYear()} Dolby — {strings.copyright}</span>
325341
</div>
326342
</div>
327343
);

frontend/src/app/VoxeetConference.js

Lines changed: 6 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -34,7 +34,7 @@ class VoxeetConference extends Component {
3434

3535
let name = this.props.userName;
3636
let photoURL = this.props.photoURL;
37-
if (this.props.userName.length == 0) {
37+
if (this.props.userName.length === 0) {
3838
name = "Guest " + Math.floor(Math.random() * 100 + 1);
3939
}
4040

@@ -78,6 +78,10 @@ class VoxeetConference extends Component {
7878
name = "Fabien";
7979
photoURL = "https://s3.amazonaws.com/voxeet-cdn/avatars/fabien.png";
8080
break;
81+
case "arthurvoxeet":
82+
name = "Arthur";
83+
photoURL = "https://bokoblin.github.io/portfolio/images/ajoli.png";
84+
break;
8185
}
8286

8387
const userInfo = {
@@ -124,9 +128,7 @@ class VoxeetConference extends Component {
124128
userInfo={userInfo}
125129
preConfig={
126130
this.props.configuration
127-
? this.props.widgetMode
128-
? false
129-
: true
131+
? !this.props.widgetMode
130132
: false
131133
}
132134
isListener={this.props.isListener}

0 commit comments

Comments
 (0)