Merge pull request #375 from DolbyIO/release/3.8.3

Release/3.8.3

Author: graduad

CHANGELOG.md

@@ -1,3 +1,11 @@
+## 3.8.3
+
+### Bug Fixes
+
+- Fixed an issue where a wrong recording status was reported by recording events.
+- Fixed an issue where a conference invitation could not be accepted on Android devices.
+- Corrected documentation for events in the notification service.
+
 ## 3.8.2
 
 ### Features

android/gradle.properties

@@ -1,2 +1,2 @@
-COMMS_SDK_VERSION="3.8.2"
+COMMS_SDK_VERSION="3.8.3"
 COMPONENT_NAME="flutter-sdk"

ios/Classes/PluginInfo.swift

@@ -2,5 +2,5 @@ import Foundation
 
 enum PluginInfo {
     static let componentName = "flutter-sdk"
-    static let sdkVersion = "3.8.2"
+    static let sdkVersion = "3.8.3"
 }

lib/src/mapper/mapper.dart

@@ -62,7 +62,9 @@ class ParticipantMapper {
 
 class ParticipantInfoMapper {
   static ParticipantInfo fromMap(Map<Object?, Object?> info) {
-    var name = info.containsKey("name") ? info["name"] as String : "";
+    String name = info.containsKey("name") && info["name"] != null
+        ? info["name"] as String
+        : "";
     var avatarUrl =
         info.containsKey("avatarUrl") ? info["avatarUrl"] as String? : null;
     var externalId =

lib/src/sdk_api/models/enums.dart

@@ -195,33 +195,6 @@ enum VideoPresentationEventNames implements EnumWithStringValue {
   }
 }
 
-/// The recording status.
-///
-/// This service is available in SDK 3.7 and later.
-/// {@category Models}
-enum RecordingStatus {
-  /// The recording is started.
-  recordingStarted('RECORDING'),
-
-  /// The recording is stopped.
-  recordingStop('NOT_RECORDING');
-
-  final String value;
-
-  const RecordingStatus(this.value);
-
-  static RecordingStatus valueOf(String? value) {
-    final lowerCaseValue = value?.toLowerCase();
-    return RecordingStatus.values.firstWhere(
-      (element) {
-        return element.value == value ||
-            element.name.toLowerCase() == lowerCaseValue;
-      },
-      orElse: () => throw Exception("Invalid enum name"),
-    );
-  }
-}
-
 /// The RecordingServiceEventNames enum gathers the recording events.
 ///
 /// {@category Models}

lib/src/sdk_api/models/events.dart

@@ -1,9 +1,8 @@
-import 'package:dolbyio_comms_sdk_flutter/src/sdk_api/models/enums.dart';
-
 import 'conference.dart';
 import 'file_presentation.dart';
 import 'participant.dart';
 import 'streams.dart';
+import 'recording.dart';
 
 typedef FileConvertedType = FileConverted;
 
@@ -234,12 +233,16 @@ class RecordingStatusUpdate {
       this.participantId, this.timeStamp);
 
   static RecordingStatusUpdate fromMap(Map<Object?, Object?> data) {
-    RecordingStatus recordingStatus =
-        RecordingStatus.valueOf(data["recordingStatus"] as String);
+    RecordingStatus? recordingStatus =
+        RecordingStatus.decode(data["recordingStatus"] as String?);
     String? conferenceId = data["conferenceId"] as String?;
     String? participantId = data["participantId"] as String?;
     int? timeStamp = data["timeStamp"] as int?;
-    return RecordingStatusUpdate(
-        recordingStatus, conferenceId, participantId, timeStamp);
+    if (recordingStatus != null) {
+      return RecordingStatusUpdate(
+          recordingStatus, conferenceId, participantId, timeStamp);
+    } else {
+      throw Exception("Invalid recording status");
+    }
   }
 }

lib/src/sdk_api/notification_service.dart

@@ -77,7 +77,7 @@ class NotificationService {
     });
   }
 
-  /// Returns a [Stream] of the [NotificationServiceEventNames.conferenceCreated] events. By subscribing to the returned stream you will be notified about new conference invitations.
+  /// Returns a [Stream] of the [NotificationServiceEventNames.conferenceCreated] events. By subscribing to the returned stream you will be notified whenever a new conference is created.
   Stream<
       Event<NotificationServiceEventNames,
           ConferenceCreatedNotificationData>> onConferenceCreated() {
@@ -90,7 +90,7 @@ class NotificationService {
     });
   }
 
-  /// Returns a [Stream] of the [NotificationServiceEventNames.conferenceEnded] events. By subscribing to the returned stream you will be notified about new conference invitations.
+  /// Returns a [Stream] of the [NotificationServiceEventNames.conferenceEnded] events. By subscribing to the returned stream you will be notified whenever a conference ends.
   Stream<Event<NotificationServiceEventNames, ConferenceEndedNotificationData>>
       onConferenceEnded() {
     return _eventStream.addListener(

pubspec.yaml

@@ -2,7 +2,7 @@ name: dolbyio_comms_sdk_flutter
 description: >
   Dolby.io Communications SDK for Flutter allows you to create high-quality video conferencing
   applications for multiple platforms using a single codebase.
-version: 3.8.2
+version: 3.8.3
 homepage: https://github.com/DolbyIO/comms-sdk-flutter
 
 environment:

test_app/pubspec.yaml

@@ -1,7 +1,7 @@
 name: dolbyio_comms_sdk_flutter_example
 description: Demonstrates how to use the dolbyio_comms_sdk_flutter plugin.
 
-version: 3.8.2+3
+version: 3.8.3+1
 
 # The following line prevents the package from being accidentally published to
 # pub.dev using `flutter pub publish`. This is preferred for private packages.