[ROCm][CI/Build] Change install location of uv #28741
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Gregory Shtrasberg <Gregory.Shtrasberg@amd.com>
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request correctly addresses the issue of uv being inaccessible to non-root users by changing its installation directory from /root/.local/bin to /usr/local/bin. This modification ensures that uv is available in a standard system-wide path, resolving potential EACCESS errors when running containers with custom user accounts. The removal of the redundant ENV PATH declaration for /root/.local/bin is also a good cleanup, as /usr/local/bin is typically already included in the system's PATH.
gshtras
added
ready
geodavic
pushed a commit
to geodavic/vllm
that referenced
this pull request
Nov 16, 2025
Signed-off-by: Gregory Shtrasberg <Gregory.Shtrasberg@amd.com> Signed-off-by: George D. Torres <gdavtor@gmail.com>
bwasti
pushed a commit
to bwasti/vllm
that referenced
this pull request
Nov 17, 2025
Signed-off-by: Gregory Shtrasberg <Gregory.Shtrasberg@amd.com> Signed-off-by: Bram Wasti <bwasti@meta.com>
bringlein
pushed a commit
to bringlein/vllm
that referenced
this pull request
Nov 26, 2025
Signed-off-by: Gregory Shtrasberg <Gregory.Shtrasberg@amd.com>
devpatelio
pushed a commit
to SumanthRH/vllm
that referenced
this pull request
Nov 29, 2025
Signed-off-by: Gregory Shtrasberg <Gregory.Shtrasberg@amd.com>
kitaekatt
pushed a commit
to kitaekatt/vllm
that referenced
this pull request
Dec 1, 2025
Signed-off-by: Gregory Shtrasberg <Gregory.Shtrasberg@amd.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A follow up for #28142 to install uv under /usr/local/bin
The rationale is that /root/.local/bin is inaccessible to non-root users, so when running a container with a custom user, there is a folder in the PATH that the user doesn't have access to.
This becomes critical in any subprocess call that is bound to fail, such as the one in /usr/local/lib/python3.12/dist-packages/torch/_dynamo/debug_utils.py that calls nvcc --version
On ROCm (and other non-NVidia platforms) it is expected to throw FileNotFound, but is currently throwing EACCESS, which has precidence over FileNotFound. So any vllm run from a non-root user would fail
Testing plan
Run a docker with
--user $(id -u):$(id -g) -v /etc/passwd:/etc/passwd:ro -v /etc/group:/etc/group:ro --group-add video --group-add renderBefore this PR any vllm run fails with
torch._inductor.exc.InductorError: PermissionError: [Errno 13] Permission denied: 'nvcc'After this PR runs succeed