-
-
Notifications
You must be signed in to change notification settings - Fork 11.7k
Feature/isaac 0.1 #28367
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Feature/isaac 0.1 #28367
Conversation
|
👋 Hi! Thank you for contributing to the vLLM project. 💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels. Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run You ask your reviewers to trigger select CI tests on top of Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging. To run CI, PR reviewers can either: Add If you have any questions, please reach out to us on Slack at https://slack.vllm.ai. 🚀 |
|
Hi Oscar. I'm very interested in this feature. Considering you meet a obstacle, if you do not mind, could I take over this feature ? I'm working on it and checking if we can use exist SiglipEncoder now. @oscardev256 |
449f2f7 to
f2347e3
Compare
|
Hi @KKSK-DON, I'm open to collaborating on this if that works with you. Let me know how you'd like to proceed. I just so happened to update the code to use the existing SiglipEncoder from siglip2navit.py, and I pushed the changes after testing. I also rebased previous commits to include the Signed-off-by line in the commit message. |
|
Hi @oscardev256 , I’m very happy to collaborate on this. May I push commits directly to this PR? This is my first time co-authoring an open-source PR, and as far as I understand I probably need to be added as a collaborator on your fork in order to be able to push commit. |
|
@KKSK-DON Invitation sent. Note that I rebased yesterday, so you may need to pull the latest changes. |
Signed-off-by: Oscar Gonzalez <ogonzal6@alumni.jh.edu>
Added Isaac model architecture. Signed-off-by: Oscar Gonzalez <ogonzal6@alumni.jh.edu>
Signed-off-by: Oscar Gonzalez <ogonzal6@alumni.jh.edu>
Signed-off-by: Oscar Gonzalez <ogonzal6@alumni.jh.edu>
Signed-off-by: Yang <lymailforjob@gmail.com>
df3b366 to
9478531
Compare
…hanisms Signed-off-by: Yang <lymailforjob@gmail.com>
|
is showing load correctly |
2. optimize Isaac model implementation. Signed-off-by: Yang <lymailforjob@gmail.com>
|
Documentation preview: https://vllm--28367.org.readthedocs.build/en/28367/ |
2. Remove deprecated xformers (vllm-project#29262) 3. Updated _get_prompt_updates() Signed-off-by: Oscar Gonzalez <ogonzal6@alumni.jh.edu>
Purpose
Support https://huggingface.co/PerceptronAI/Isaac-0.1 on vLLM: [New Model]: Issac 0.1 #25448
Test Plan
Compare output to Hugging Face example repo:
https://github.com/perceptron-ai-inc/perceptron/tree/main/huggingface
Test Result
Output from Hugging Face example repo:
Output from vLLM implementation:
Essential Elements of an Effective PR Description Checklist
supported_models.mdandexamplesfor a new model.