-
-
Notifications
You must be signed in to change notification settings - Fork 11.7k
[CI/Build] Skip encoder-decoder models on AMD #28156
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Signed-off-by: zhewenli <zhewenli@meta.com>
Signed-off-by: zhewenli <zhewenli@meta.com>
3a61e41 to
adce919
Compare
|
cc @russellb @robertgshaw2-redhat AFAIR we have reached an agreement that the only enc-dec model we're going to support in V1 is whisper, so we should deprecate other models. |
Signed-off-by: zhewenli <zhewenli@meta.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💡 Codex Review
Here are some automated review suggestions for this pull request.
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
Signed-off-by: zhewenli <zhewenli@meta.com>
Signed-off-by: zhewenli <zhewenli@meta.com>
|
@DarkLight1337 Thanks for catching this! Updated list and relevant tests |
Purpose
See more details in #27442. Encoder-decoder models (Whisper, T5, BART, vision-language models) fail on AMD ROCm with NotImplementedError because all ROCm-specific attention backends only support decoder-only models.
Therefore, all the tests using these models will fail on AMD CI(example), mainly in Entrypoints Integration Test (API Server) and Entrypoints Integration Test (Pooling):
In this PR:
@pytest.mark.encoder_decoderon specific tests/variants; also fixed some tests not using parametrized fixtures.test-amd.yaml.Test Plan
CI: https://buildkite.com/vllm/amd-ci/builds/1020