-
-
Notifications
You must be signed in to change notification settings - Fork 11.7k
[CI/Build] Install uv for AMD MI300: Language Models Tests (Hybrid) %N #28142
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: amdfaa <107946068+amdfaa@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request fixes a CI failure in the 'AMD MI300: Language Models Tests' job by installing uv before it is used. The change is correct and directly addresses the uv: command not found error. I have one suggestion to pin the version of uv to ensure build reproducibility and prevent potential breakages from future uv releases. This is a standard practice for maintaining stable CI environments.
.buildkite/test-pipeline.yaml
Outdated
| commands: | ||
| # Install fast path packages for testing against transformers | ||
| # Note: also needed to run plamo2 model in vLLM | ||
| - pip install uv |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For better reproducibility and to prevent unexpected build failures due to updates in uv, it's recommended to pin the version of uv being installed. This ensures that the CI environment remains stable and predictable over time. Please pin it to a recent, stable version that is known to work.
- pip install uv==0.2.21Signed-off-by: amdfaa <107946068+amdfaa@users.noreply.github.com>
|
let's fix it in |
That makes sense. I'll add it to the requirements file and remove the current changes. @zhewenl |
Signed-off-by: amdfaa <107946068+amdfaa@users.noreply.github.com>
Removed specific version pinning for uv package. Signed-off-by: amdfaa <107946068+amdfaa@users.noreply.github.com>
I am not sure if adding to deps list is sufficient - maybe trigger a test on AMD CI to test if uv issue is gone? |
This is a recent run based on my commit to add package to the dependencies. It looks like it worked. Can you confirm this and merge if you think it's good @zhewenl ? https://buildkite.com/vllm/ci/builds/37752/steps/canvas?sid=019a55dd-7925-4543-bff0-be282fbbbec0 |
|
A bit late, but rather than changing the build process for the production image in order to fix the tests, potentially locking the run scenarios to the root user, isn't it better to address the test issue in the test? |
vllm-project#28142) Signed-off-by: amdfaa <107946068+amdfaa@users.noreply.github.com> Signed-off-by: zhewenli <zhewenli@meta.com> Co-authored-by: zhewenli <zhewenli@meta.com> Signed-off-by: George D. Torres <gdavtor@gmail.com>
vllm-project#28142) Signed-off-by: amdfaa <107946068+amdfaa@users.noreply.github.com> Signed-off-by: zhewenli <zhewenli@meta.com> Co-authored-by: zhewenli <zhewenli@meta.com> Signed-off-by: Bram Wasti <bwasti@meta.com>
vllm-project#28142) Signed-off-by: amdfaa <107946068+amdfaa@users.noreply.github.com> Signed-off-by: zhewenli <zhewenli@meta.com> Co-authored-by: zhewenli <zhewenli@meta.com>
Purpose
This PR is for fixing the AMD MI300: Language Models Tests (Hybrid) %N failing with uv: command not found
See failing build:
https://buildkite.com/vllm/ci/builds/37631/steps/canvas?sid=019a5264-347a-407b-8a34-6d54a2f8e82f
Test Plan
Test Result
Essential Elements of an Effective PR Description Checklist
supported_models.mdandexamplesfor a new model.