Skip to content

Commit c245d16

Browse files
committed
Add github user id to TODO
Signed-off-by: Yong Hoon Shin <yhshin@meta.com>
1 parent d33f8f2 commit c245d16

File tree

1 file changed

+2
-1
lines changed

1 file changed

+2
-1
lines changed

vllm/model_executor/layers/rotary_embedding.py

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -211,7 +211,8 @@ def forward_xpu(
211211
# are in-place operations that update the query and key tensors.
212212
if key is None:
213213
# XPU kernel doesn't support key=None so fall back to native impl
214-
# TODO ipex.llm.functional.rotary_embedding_batched support key=None
214+
# TODO(sarckk): add support for optional key in
215+
# ipex.llm.functional.rotary_embedding_batched
215216
return self.forward_native(positions, query, key, offsets)
216217
else:
217218
if offsets is not None:

0 commit comments

Comments
 (0)