Commit d61eeeb
fix(e2e): make PII test model name configurable via environment variable
The PII detection E2E test was hardcoding "model": "general-expert" in
the chat completions request, which caused failures in deployments that
use different model names (e.g., aibrix uses "vllm-llama3-8b-instruct").
This commit makes the model name configurable via the E2E_TEST_MODEL
environment variable, while maintaining backward compatibility by
defaulting to "general-expert" for existing profiles (ai-gateway,
dynamic-config).
Changes:
- Add E2E_TEST_MODEL environment variable support in pii_detection.go
- Default to "general-expert" when E2E_TEST_MODEL is not set
- Enable future profiles (e.g., aibrix) to specify custom model names
Testing:
- Tested locally with dynamic-config profile: 100/100 tests passed (100% accuracy)
- Tested locally with ai-gateway profile: 100/100 tests passed (100% accuracy)
🤖 Generated with [Claude Code](https://claude.com/claude-code)
Co-Authored-By: Claude <noreply@anthropic.com>
Signed-off-by: Yossi Ovadia <yovadia@redhat.com>1 parent 8df29e7 commit d61eeeb
1 file changed
+7
-1
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
133 | 133 | | |
134 | 134 | | |
135 | 135 | | |
| 136 | + | |
| 137 | + | |
| 138 | + | |
| 139 | + | |
| 140 | + | |
| 141 | + | |
136 | 142 | | |
137 | 143 | | |
138 | | - | |
| 144 | + | |
139 | 145 | | |
140 | 146 | | |
141 | 147 | | |
| |||
0 commit comments