Skip to content

Commit a254895

Browse files
committed
more fixes
1 parent bea7316 commit a254895

File tree

3 files changed

+20
-16
lines changed

3 files changed

+20
-16
lines changed

src/LibVLCSharp.Tests/MediaPlayerTests.cs

Lines changed: 7 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -75,7 +75,7 @@ public async Task ChapterDescriptions()
7575
[Test]
7676
public async Task Play()
7777
{
78-
var media = new Media("http://www.quirksmode.org/html5/videos/big_buck_bunny.mp4", FromType.FromLocation);
78+
var media = new Media(new Uri(LocalAudioFile));
7979
var mp = new MediaPlayer(_libVLC, media);
8080
var called = false;
8181
mp.Playing += (sender, args) =>
@@ -85,7 +85,6 @@ public async Task Play()
8585
mp.Play();
8686
await Task.Delay(5000);
8787
Assert.True(called);
88-
//Assert.True(mp.IsPlaying);
8988
}
9089

9190
int callCountRegisterOne = 0;
@@ -96,7 +95,7 @@ public async Task EventFireOnceForeachRegistration()
9695
{
9796
try
9897
{
99-
var media = new Media("http://www.quirksmode.org/html5/videos/big_buck_bunny.mp4", FromType.FromLocation);
98+
var media = new Media(new Uri(LocalAudioFile));
10099
var mp = new MediaPlayer(_libVLC, media);
101100

102101

@@ -185,7 +184,7 @@ public async Task UpdateViewpoint()
185184
{
186185
var mp = new MediaPlayer(_libVLC);
187186

188-
mp.Play(new Media("https://streams.videolan.org/streams/360/eagle_360.mp4", FromType.FromLocation));
187+
mp.Play(new Media(new Uri("https://streams.videolan.org/streams/360/eagle_360.mp4"), ":no-video"));
189188

190189
await Task.Delay(1000);
191190

@@ -204,17 +203,17 @@ public async Task UpdateViewpoint()
204203
public void GetMediaPlayerRole()
205204
{
206205
var mp = new MediaPlayer(_libVLC);
207-
Assert.AreEqual(MediaPlayerRole.None, mp.Role);
206+
Assert.AreEqual(MediaPlayerRole.Video, mp.Role);
208207
}
209208

210209
[Test]
211210
public void SetMediaPlayerRole()
212211
{
213212
var mp = new MediaPlayer(_libVLC);
214-
Assert.AreEqual(MediaPlayerRole.None, mp.Role);
215-
216-
Assert.True(mp.SetRole(MediaPlayerRole.Video));
217213
Assert.AreEqual(MediaPlayerRole.Video, mp.Role);
214+
215+
Assert.True(mp.SetRole(MediaPlayerRole.Music));
216+
Assert.AreEqual(MediaPlayerRole.Music, mp.Role);
218217
}
219218

220219
[Test]

src/LibVLCSharp.Tests/MediaTests.cs

Lines changed: 9 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -62,14 +62,19 @@ public void AddOption()
6262
}
6363

6464
[Test]
65-
public async Task CreateRealMedia()
65+
public async Task CheckStats()
6666
{
67-
using var media = new Media(new Uri(LocalAudioFile));
67+
using var media = new Media(new Uri(RemoteVideoStream));
6868
Assert.NotZero(media.Duration);
6969
using var mp = new MediaPlayer(_libVLC, media);
70+
7071
Assert.True(mp.Play());
71-
await Task.Delay(4000); // have to wait a bit for statistics to populate
72-
Assert.Greater(media.Statistics.DemuxBitrate, 0);
72+
73+
await Task.Delay(5000); // have to wait a bit for statistics to populate
74+
75+
Assert.NotZero(media.Statistics.DemuxBitrate);
76+
Assert.NotZero(media.Statistics.ReadBytes);
77+
7378
mp.Stop();
7479
}
7580

src/LibVLCSharp/Structures/MediaTrack.cs

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -311,7 +311,7 @@ public MediaTrack? this[uint position]
311311

312312
internal class MediaTrackListEnumerator : IEnumerator<MediaTrack>
313313
{
314-
uint position = 0;
314+
int position = -1;
315315
MediaTrackList? _mediaTrackList;
316316

317317
internal MediaTrackListEnumerator(MediaTrackList mediaTrackList)
@@ -327,12 +327,12 @@ public bool MoveNext()
327327

328328
void IEnumerator.Reset()
329329
{
330-
position = 0;
330+
position = -1;
331331
}
332332

333333
public void Dispose()
334334
{
335-
position = 0;
335+
position = -1;
336336
_mediaTrackList = default;
337337
}
338338

@@ -346,7 +346,7 @@ public MediaTrack Current
346346
{
347347
throw new ObjectDisposedException(nameof(MediaTrackListEnumerator));
348348
}
349-
return _mediaTrackList[position] ?? throw new ArgumentOutOfRangeException(nameof(position));
349+
return _mediaTrackList[position < 0 ? 0 : (uint)position] ?? throw new ArgumentOutOfRangeException(nameof(position));
350350
}
351351
}
352352
}

0 commit comments

Comments
 (0)