Skip to content

Commit 6c226a1

Browse files
introduce FormatConfig class
1 parent 8abd429 commit 6c226a1

File tree

5 files changed

+18
-23
lines changed

5 files changed

+18
-23
lines changed

js/src/main/scala/com/github/vertical_blank/sqlformatter/scala/SqlFormatter.scala

Lines changed: 6 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -12,19 +12,16 @@ private[scala] object Facade extends js.Object {
1212

1313
object SqlFormatter extends AbstractSqlFormatter {
1414
def format(sql: String,
15-
dialect: SqlDialect,
16-
indent: String): String =
17-
Facade.format(sql, js.Dictionary("language" -> dialect.name, "indent" -> indent))
15+
config: FormatConfig): String =
16+
Facade.format(sql, js.Dictionary("language" -> config.dialect.name, "indent" -> config.indent))
1817

1918
def formatWithNamedParams(sql: String,
2019
params: Map[String, Any],
21-
dialect: SqlDialect,
22-
indent: String): String =
23-
Facade.format(sql, js.Dictionary("language" -> dialect.name, "indent" -> indent, "params" -> params.toJSDictionary))
20+
config: FormatConfig): String =
21+
Facade.format(sql, js.Dictionary("language" -> config.dialect.name, "indent" -> config.indent, "params" -> params.toJSDictionary))
2422

2523
def formatWithIndexedParams(sql: String,
2624
params: Seq[Any],
27-
dialect: SqlDialect,
28-
indent: String): String =
29-
Facade.format(sql, js.Dictionary("language" -> dialect.name, "indent" -> indent, "params" -> params.toJSArray))
25+
config: FormatConfig): String =
26+
Facade.format(sql, js.Dictionary("language" -> config.dialect.name, "indent" -> config.indent, "params" -> params.toJSArray))
3027
}

jvm/src/main/scala/com/github/vertical_blank/sqlformatter/scala/SqlFormatter.scala

Lines changed: 3 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -5,16 +5,13 @@ import com.github.vertical_blank.sqlformatter.{SqlFormatter => JSqlFormatter}
55

66
object SqlFormatter extends AbstractSqlFormatter {
77
def format(sql: String,
8-
dialect: SqlDialect,
9-
indent: String): String = JSqlFormatter.of(dialect.name).format(sql, indent)
8+
config: FormatConfig): String = JSqlFormatter.of(config.dialect.name).format(sql, config.indent)
109

1110
def formatWithNamedParams(sql: String,
1211
params: Map[String, Any],
13-
dialect: SqlDialect,
14-
indent: String): String = JSqlFormatter.of(dialect.name).format(sql, indent, params.asJava)
12+
config: FormatConfig): String = JSqlFormatter.of(config.dialect.name).format(sql, config.indent, params.asJava)
1513

1614
def formatWithIndexedParams(sql: String,
1715
params: Seq[Any],
18-
dialect: SqlDialect,
19-
indent: String): String = JSqlFormatter.of(dialect.name).format(sql, indent, params.asJava)
16+
config: FormatConfig): String = JSqlFormatter.of(config.dialect.name).format(sql, config.indent, params.asJava)
2017
}

shared/src/main/scala/com/github/vertical_blank/sqlformatter/scala/AbstractSqlFormatter.scala

Lines changed: 3 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -2,17 +2,13 @@ package com.github.vertical_blank.sqlformatter.scala
22

33
trait AbstractSqlFormatter {
44

5-
def format(sql: String,
6-
dialect: SqlDialect = SqlDialect.StandardSQL,
7-
indent: String = " "): String
5+
def format(sql: String, config: FormatConfig = FormatConfig()): String
86

97
def formatWithNamedParams(sql: String,
108
params: Map[String, Any],
11-
dialect: SqlDialect = SqlDialect.StandardSQL,
12-
indent: String = " "): String
9+
config: FormatConfig = FormatConfig()): String
1310

1411
def formatWithIndexedParams(sql: String,
1512
params: Seq[Any],
16-
dialect: SqlDialect = SqlDialect.StandardSQL,
17-
indent: String = " "): String
13+
config: FormatConfig = FormatConfig()): String
1814
}
Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
1+
package com.github.vertical_blank.sqlformatter.scala
2+
3+
case class FormatConfig(
4+
dialect: SqlDialect = SqlDialect.StandardSQL,
5+
indent: String = " ")

shared/src/test/scala/com/github/vertical_blank/sqlformatter/scala/BaseTest.scala

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -34,7 +34,7 @@ abstract class BaseTest(sqlFormatter: AbstractSqlFormatter) extends FunSuite {
3434
| table""".stripMargin
3535

3636
assert(sqlFormatter
37-
.format("SELECT foo, bar, CASE baz WHEN 'one' THEN 1 WHEN 'two' THEN 2 ELSE 3 END FROM table", indent = " ") == formatted)
37+
.format("SELECT foo, bar, CASE baz WHEN 'one' THEN 1 WHEN 'two' THEN 2 ELSE 3 END FROM table", FormatConfig(indent = " ")) == formatted)
3838
}
3939

4040
test("withNamedParams") {

0 commit comments

Comments
 (0)