Skip to content

fix the issue for pack pattern to recognize register connection #3331

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 4, 2025
+3 −2
Merged

fix the issue for pack pattern to recognize register connection #3331

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
423fd0d
fix the issue for pack pattern to recognize register connection
saaramahmoudi Nov 4, 2025
4621cd3
added a comment to explain the condition purpose
saaramahmoudi Nov 4, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions vpr/src/pack/prepack.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1141,11 +1141,12 @@ static AtomBlockId get_sink_block(const AtomBlockId block_id,
// Iterate through all sink blocks and check whether any of them
// is compatible with the block specified in the pack pattern.
bool connected_to_latch = false;
LogicalModelId latch_model_id = LogicalModels::MODEL_LATCH_ID;
AtomBlockId pattern_sink_block_id = AtomBlockId::INVALID();
for (const auto& sink_pin_id : net_sinks) {
auto sink_block_id = atom_nlist.pin_block(sink_pin_id);
if (atom_nlist.block_model(sink_block_id) == latch_model_id) {
// If the sink block has a clock, it is considered stateful (e.g., a latch or flip-flop).
// Mark this so we can later decide whether to drop the block based on the net’s fanout.
if (!atom_nlist.block_is_combinational(sink_block_id)) {
connected_to_latch = true;
}
if (primitive_type_feasible(sink_block_id, to_pb_type)) {
Expand Down