[CI] Fix Golden Results #2768
Merged
[CI] Fix Golden Results #2768
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Golden results are incorrect for the strong tests after recent merge conflicts.
Contributor
Author
|
@vaughnbetz This PR fixes the golden results for the strong tests. Please merge when you have a moment. It is still failing the basic tests with the highest assertion level due to the timing issue in the router: |
Contributor
|
Thanks Alex. We could temporarily disable the failing test too. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Golden results are incorrect for the strong tests after recent merge conflicts.
There may still be an issue with the basic with highest assertions test. See issue #2754