Merge pull request #2275 from verilog-to-routing/xt_ci_build_compatibility

Expand build compatibility on GCC and Clang for Ubuntu 22.04

Author: vaughnbetz

.github/scripts/install_dependencies.sh

@@ -43,15 +43,19 @@ sudo apt install -y \
   qtbase5-dev \
   uuid-dev \
   default-jdk \
-  clang \
-  clang-format-12 \
   g++-9 \
   gcc-9 \
   g++-10 \
   gcc-10 \
   g++-11 \
   gcc-11 \
+  g++-12 \
+  gcc-12 \
+  clang-11 \
   clang-12 \
+  clang-13 \
+  clang-14 \
+  clang-format-14 \
   libtbb12
 
 pip install -r requirements.txt

.github/workflows/build_dependency_ubuntu-22.04.sh

@@ -363,7 +363,11 @@ jobs:
         - { name: 'GCC 9 (Ubuntu Jammy - 22.04)',     eval: 'CC=gcc-9 && CXX=g++-9',           }
         - { name: 'GCC 10 (Ubuntu Jammy - 22.04)',  eval: 'CC=gcc-10 && CXX=g++-10',         }
         - { name: 'GCC 11 (Ubuntu Jammy - 22.04)',                  eval: 'CC=gcc-11 && CXX=g++-11',         }
+        - { name: 'GCC 12 (Ubuntu Jammy - 22.04)',                  eval: 'CC=gcc-12 && CXX=g++-12',         }
+        - { name: 'Clang 11 (Ubuntu Jammy - 22.04)',  eval: 'CC=clang-11 && CXX=clang++-11',   }
         - { name: 'Clang 12 (Ubuntu Jammy - 22.04)',  eval: 'CC=clang-12 && CXX=clang++-12',   }
+        - { name: 'Clang 13 (Ubuntu Jammy - 22.04)',  eval: 'CC=clang-13 && CXX=clang++-13',   }
+        - { name: 'Clang 14 (Ubuntu Jammy - 22.04)',  eval: 'CC=clang-14 && CXX=clang++-14',   }
     name: 'B: ${{ matrix.name }}'
     steps:
 

.github/workflows/test.yml

@@ -120,7 +120,7 @@ struct edge_swapper {
         std::swap(a.storage_->edge_src_node_[a_edge], a.storage_->edge_src_node_[b_edge]);
         std::swap(a.storage_->edge_dest_node_[a_edge], a.storage_->edge_dest_node_[b_edge]);
         std::swap(a.storage_->edge_switch_[a_edge], a.storage_->edge_switch_[b_edge]);
-        std::swap(a.storage_->edge_remapped_[a_edge], a.storage_->edge_remapped_[b_edge]);
+        std::vector<bool>::swap(a.storage_->edge_remapped_[a_edge], a.storage_->edge_remapped_[b_edge]);
     }
 
     friend void swap(edge_swapper& a, edge_swapper& b) {

libs/librrgraph/src/base/rr_graph_storage.cpp

@@ -71,10 +71,10 @@ class Point {
     T y() const;
 
     ///@brief == operator
-    friend bool operator==<>(Point<T> lhs, Point<T> rhs);
+    friend bool operator== <>(Point<T> lhs, Point<T> rhs);
 
     ///@brief != operator
-    friend bool operator!=<>(Point<T> lhs, Point<T> rhs);
+    friend bool operator!= <>(Point<T> lhs, Point<T> rhs);
 
     ///@brief < operator
     friend bool operator< <>(Point<T> lhs, Point<T> rhs);
@@ -172,10 +172,10 @@ class Rect {
     bool empty() const;
 
     ///@brief == operator
-    friend bool operator==<>(const Rect<T>& lhs, const Rect<T>& rhs);
+    friend bool operator== <>(const Rect<T>& lhs, const Rect<T>& rhs);
 
     ///@brief != operator
-    friend bool operator!=<>(const Rect<T>& lhs, const Rect<T>& rhs);
+    friend bool operator!= <>(const Rect<T>& lhs, const Rect<T>& rhs);
 
   public: //Mutators
     ///@brief set xmin to a point
@@ -296,10 +296,10 @@ class RectUnion {
      *
      * Note: does not check whether the representations they are equivalent
      */
-    friend bool operator==<>(const RectUnion<T>& lhs, const RectUnion<T>& rhs);
+    friend bool operator== <>(const RectUnion<T>& lhs, const RectUnion<T>& rhs);
 
     ///@brief != operator
-    friend bool operator!=<>(const RectUnion<T>& lhs, const RectUnion<T>& rhs);
+    friend bool operator!= <>(const RectUnion<T>& lhs, const RectUnion<T>& rhs);
 
   private:
     // Note that a union of rectanges may have holes and may not be contiguous

libs/libvtrutil/src/vtr_geometry.h

@@ -202,9 +202,9 @@ class StrongId {
      * Note that since these are templated functions we provide an empty set of template parameters
      * after the function name (i.e. <>)
      */
-    friend bool operator==<>(const StrongId<tag, T, sentinel>& lhs, const StrongId<tag, T, sentinel>& rhs);
+    friend bool operator== <>(const StrongId<tag, T, sentinel>& lhs, const StrongId<tag, T, sentinel>& rhs);
     ///@brief != operator
-    friend bool operator!=<>(const StrongId<tag, T, sentinel>& lhs, const StrongId<tag, T, sentinel>& rhs);
+    friend bool operator!= <>(const StrongId<tag, T, sentinel>& lhs, const StrongId<tag, T, sentinel>& rhs);
     ///@brief < operator
     friend bool operator< <>(const StrongId<tag, T, sentinel>& lhs, const StrongId<tag, T, sentinel>& rhs);