Commit 3db98cc
committed
Fix intermittent abort when running tests on macOS
The problem was again that tests weren't cleaning up after themselves
properly, and were then breaking subsequent tests: this time, they were
correctly calling `NocStorage::clear_noc`, but that was failing to clear
`router_id_conversion_table`.
Since `unordered_map::emplace` is used to add entries to that table,
writing to an entry that's already been filled doesn't do anything, and
so subsequent reads wil retrieve the data from previous tests: the
retrieved IDs are then used as indices, causing out-of-bounds array
accesses and an eventual crash.1 parent 067b4a9 commit 3db98cc
1 file changed
+1
-0
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
256 | 256 | | |
257 | 257 | | |
258 | 258 | | |
| 259 | + | |
259 | 260 | | |
260 | 261 | | |
261 | 262 | | |
| |||
0 commit comments